Add changes for the final run #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is based on feedback from discussion on Github mainly around filesystem cache bia in-between runs and ensuring correctness. * We now should run solutions against a bunch of input/output pairs of 1M rows each and verify that they produce the correct input and exit early if there is a failure. * We drop the Linux filesystem cache after syncing any dirty pages to Disk before each run. * The runner will now run for 10 times (5 more times) to ensure minimal variance, and also we will drop the two most outliers when counting the results (slowest and fastest solutions).
|
I will still need to test this on a live setting, and ensure that the changes are applied for all languages before we merge this. |
aboullaite
approved these changes
Mar 2, 2024
| @@ -142,12 +163,33 @@ fn compute_verdict(output: &Path, expected_output: &Path) -> Result<Verdict> { | |||
| output.read_to_string(&mut output_str)?; | |||
| expected_output.read_to_string(&mut ex_output_str)?; | |||
| if output_str.trim() != ex_output_str.trim() { | |||
There was a problem hiding this comment.
Will that mean solutions with an additional line in the end would fail ?
There was a problem hiding this comment.
Why would they? (we still compare the trimmed version of both so it should be fine)
There was a problem hiding this comment.
Just double checking, as some submissions (most?) are adding a new line at the end
aboullaite
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is based on feedback from discussion on Github mainly around filesystem cache bia in-between runs and ensuring correctness.