Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: API requests can take down whole site #2607

Open
kimadactyl opened this issue Sep 9, 2024 — with Huly for GitHub · 1 comment
Open

[Bug]: API requests can take down whole site #2607

kimadactyl opened this issue Sep 9, 2024 — with Huly for GitHub · 1 comment
Labels
bug Release Drafter category - bug impacting the normal functioning of existing features vvv Very Very Valuable

Comments

Copy link
Member

kimadactyl commented Sep 9, 2024

Description

I was messing around with the TransDim repo and noticed that the PlaceCal.org main site was down due to our AppSignal monitoring. On further investigation the requests being sent by TransDim locally effectivly denial-of-service'd the whole PlaceCal site. I'm not 100% on cause here but it looks like a very likely suspect.

It should not be this easy to take down the whole PlaceCal site and this needs mitigating somehow.

Steps to reproduce

  1. Load up TransDim repo
  2. Set PLACECAL_API=https://placecal.org/api/v1/graphql in .env
  3. Muck about a bit
  4. Note downtime from PlaceCal.org

What you expected to happen

What would you like to happen instead?

Platform (if relevant)

What device and browser were you using?

Possible fixes

@kimadactyl kimadactyl added the bug Release Drafter category - bug impacting the normal functioning of existing features label Sep 9, 2024
@kimadactyl kimadactyl added the vvv Very Very Valuable label Sep 9, 2024
@kimadactyl
Copy link
Member Author

@katjam - unsure best way to address this? API authentication and/or some kind of rate limiting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release Drafter category - bug impacting the normal functioning of existing features vvv Very Very Valuable
Projects
None yet
Development

No branches or pull requests

1 participant