Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular deprecation affects 'Node Exporter' Grafana dashboard #588

Closed
falkecarlsen opened this issue Mar 18, 2024 · 9 comments
Closed

Angular deprecation affects 'Node Exporter' Grafana dashboard #588

falkecarlsen opened this issue Mar 18, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@falkecarlsen
Copy link

https://grafana.com/docs/grafana/latest/developers/angular_deprecation/

@mschirrmeister
Copy link

You can change the uptime panel from Statusmap to Status history for a test. Here is an example what I currently have in a modified dashboard.

grafana_status_history

I did also set the Max data points to 365 (no idea what an ideal value is). Otherwise it was choking. Similar to other panels with certain time ranges, where it cannot display data.

At least it still looks similar and ok. But don't know if it is an appropriate one.
Will be interesting what @geerlingguy has in mind for a new panel type. 😎

@martinbrose
Copy link
Contributor

Seems to be now a problem that breaks this overview:
Screenshot 2024-06-01 at 16 49 00

Running grafana/grafana:latest, just pulled and it's the version that was pushed 4 days ago.

@quadespresso
Copy link
Contributor

fwiw: #598 (comment)

@geerlingguy geerlingguy added the bug Something isn't working label Jun 3, 2024
@martinbrose
Copy link
Contributor

Thanks @quadespresso,

we might just need to raise a pull request to fix this real quick with your interim solution...
Do you want to raise one?

Cheers

@quadespresso
Copy link
Contributor

Sure thing, @martinbrose. Is it just a simple matter of exporting my dashboard?

I'll dig around to see if I can figure out whether it's as straightforward as that, or something considerably less verbose.

@quadespresso
Copy link
Contributor

fyi my comments here might cross over into #598 (and vice-versa). Adding @mschirrmeister to this thread for visibility. And @butchkemper as well, due to them accepting my suggestion absent additional scrutiny.

So I exported my dashboard and diff'd against https://github.com/geerlingguy/internet-pi/blob/4.0.0/internet-monitoring/grafana/provisioning/dashboards/internet-connection.json and found a fair number of other things have been updated as well.

I'm happy to file a PR with this change. But the PR may well impact other facets of the dashboard, for better or for worse.

I suppose I could phrase it as "2024-06 Internet Connection dashboard update" and include a mention of the plugin update for the Uptime panel plugin? The very nature of "includes other random things you probably didn't ask for" grates against my own sensibilities.

Let me know your thoughts. I can always set up the PR, and we can continue the discussion there.

@quadespresso
Copy link
Contributor

PR created for discussion: #599

@geerlingguy
Copy link
Owner

Should be fixed now, let me know if not!

@DWomack
Copy link

DWomack commented Jun 14, 2024

Hey Jeff how 'bout fixing your internet-monitoring? I use it instead of internet-pi. I already have a pi running docker compose.

Thanks

Dennis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants