-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular deprecation affects 'Node Exporter' Grafana dashboard #588
Comments
You can change the uptime panel from I did also set the At least it still looks similar and ok. But don't know if it is an appropriate one. |
fwiw: #598 (comment) |
Thanks @quadespresso, we might just need to raise a pull request to fix this real quick with your interim solution... Cheers |
Sure thing, @martinbrose. Is it just a simple matter of exporting my dashboard? I'll dig around to see if I can figure out whether it's as straightforward as that, or something considerably less verbose. |
fyi my comments here might cross over into #598 (and vice-versa). Adding @mschirrmeister to this thread for visibility. And @butchkemper as well, due to them accepting my suggestion absent additional scrutiny. So I exported my dashboard and diff'd against https://github.com/geerlingguy/internet-pi/blob/4.0.0/internet-monitoring/grafana/provisioning/dashboards/internet-connection.json and found a fair number of other things have been updated as well. I'm happy to file a PR with this change. But the PR may well impact other facets of the dashboard, for better or for worse. I suppose I could phrase it as "2024-06 Internet Connection dashboard update" and include a mention of the plugin update for the Uptime panel plugin? The very nature of "includes other random things you probably didn't ask for" grates against my own sensibilities. Let me know your thoughts. I can always set up the PR, and we can continue the discussion there. |
PR created for discussion: #599 |
Should be fixed now, let me know if not! |
Hey Jeff how 'bout fixing your internet-monitoring? I use it instead of internet-pi. I already have a pi running docker compose. Thanks Dennis |
https://grafana.com/docs/grafana/latest/developers/angular_deprecation/
The text was updated successfully, but these errors were encountered: