Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gefyra-run: certain (docker) runtime errors are ignored (RC=0) #746

Open
crkurz opened this issue Nov 8, 2024 · 0 comments
Open

gefyra-run: certain (docker) runtime errors are ignored (RC=0) #746

crkurz opened this issue Nov 8, 2024 · 0 comments
Labels
triage To be investigated

Comments

@crkurz
Copy link

crkurz commented Nov 8, 2024

What happened?

gefyra-run only fails (RC>0) in case of early errors, e.g. invalid parameters. But in case of Docker errors like

      409 Client Error for http+docker://localhost/v1.40/containers/0f2a06510ea1e5d0721f59fea15a1cc1de8f66ea31716dda408cf122e9e82705/exec: Conflict ("Container 0f2a06510ea1e5d0721f59fea15a1cc1de8f66ea31716dda408cf122e9e82705 is not running")

docker-run prints the error msg, but still returns RC=0. In this particular case the cargo container was down due to a docker-daemon restart.

What did you expect to happen?

gefyra-run should have return RC>0.

RC handling is import when gefyra-run is used for automation or inside some wrapper scripts.

Please provide the output of gefyra check.

.

How can we reproduce it (as minimally and precisely as possible)?

.

What Kubernetes setup are you working with?

.

OS version

.

Anything else we need to know?

No response

@SteinRobert SteinRobert added the triage To be investigated label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage To be investigated
Projects
None yet
Development

No branches or pull requests

2 participants