Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gefyra-bridge: no error msg on unsupported probe types #739

Open
crkurz opened this issue Nov 5, 2024 · 0 comments · May be fixed by #763
Open

gefyra-bridge: no error msg on unsupported probe types #739

crkurz opened this issue Nov 5, 2024 · 0 comments · May be fixed by #763

Comments

@crkurz
Copy link

crkurz commented Nov 5, 2024 •
edited
Loading

What happened?

When pod contains socket-type or exec-type probes (anything other than http-type probes), setprobe.sh is unable to handle. The problem is silently ignored which leads the user to assume probing was successful.

gefyra-run hangs with no error msg

What did you expect to happen?

gefyra-bridge to check probe-types in Carrier._ensure_probes() and error out with "Pod xyz uses non-http-type probes, which is not supported. Please consider option --no-probe-handling."

Please provide the output of gefyra check.

.

How can we reproduce it (as minimally and precisely as possible)?

run gefyra-bridge on any pod which has e.g. an exec-type probe

What Kubernetes setup are you working with?

.

OS version

No response

Anything else we need to know?

No response
liquidiert added a commit that referenced this issue Dec 11, 2024
@liquidiert
feat(#739): add probe check in client and operator
c610996 
  - add e2e unit tests for operator
@liquidiert liquidiert linked a pull request Dec 11, 2024 that will close this issue
Open
liquidiert added a commit that referenced this issue Dec 11, 2024
@liquidiert
fix(#739): remove unknown import for earlier python versions
cc79f16
liquidiert added a commit that referenced this issue Dec 18, 2024
@liquidiert
feat(#739): unsupported probes
be4df84 
  - refactor exceptions
  - refactor unit tests
  - add post event for on impair
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#739): add probe check in client and operator gefyrahq/gefyra
1 participant
@crkurz