Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that every python module can be imported on its own #8309

Open
msullivan opened this issue Feb 5, 2025 · 1 comment
Open

Test that every python module can be imported on its own #8309

msullivan opened this issue Feb 5, 2025 · 1 comment

Comments

@msullivan
Copy link
Member

... and fix the ones that can't, which I'm sure there are many.

This will make sure that our import cycles are resilient to being imported in any order.
Something that would have been caught by this caused LSP to break (see #8307)

@aljazerzen
Copy link
Contributor

This will be a hard nut to crack - there is a lot of cross-references between modules.

Maybe we should first start by pulling a module out of the loop, so that it does not refer to any other modules anymore.

For example, edb/schema/ is a data structure that should be able to exist on its own. So we could remove all external references it contains (to edb/pgsql and edb/edgeql). That would require moving DDL code out into a separate module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants