Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for changing between readonly and full access for CoIs. #4526

Merged

Conversation

toddburnside
Copy link
Contributor

Also, Andy told me that the default for a CoI should be Readonly. So, now all CoIs are initially added as Readonly, but can be changed to Full Access via the dropdown in the program users table.

@@ -395,7 +398,27 @@ object ProgramUsersTable:
).sortableBy(_.get.toString),
column(Column.OrcidId, _.get.user.flatMap(_.orcidId).foldMap(_.value)).sortable,
// TODO: Make editable between COI and Readonly COI, if user is not this one
column(Column.Role, _.get.role.shortName).sortable,
// column(Column.Role, _.get.role.shortName).sortable,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented line

Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

bundlemon bot commented Jan 28, 2025

BundleMon

Files updated (1)
Status Path Size Limits
index-(hash).js
1.74MB (+1.17KB +0.07%) -
Unchanged files (7)
Status Path Size Limits
exploreworkers-(hash).js
597.75KB -
index-(hash).css
66.14KB -
workbox-window.prod.es5-(hash).js
2.07KB -
catalogworker-(hash).js
85B -
itcworker-(hash).js
82B -
plotworker-(hash).js
80B -
agsworker-(hash).js
78B -

Total files change +1.17KB +0.05%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@toddburnside toddburnside merged commit 7e967b1 into main Jan 28, 2025
14 checks passed
@toddburnside toddburnside deleted the sc-4015-ability-to-update-collaborator-s-access-privileges branch January 28, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants