Prevent proposal submission with undefined observations #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (1)
Unchanged files (7)
Total files change +402B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
swalker2m
approved these changes
Feb 6, 2025
| ): (ps, _, he) => | ||
| if (he && ps === ProposalStatus.NotSubmitted) | ||
| errorMessage.set( | ||
| "Proposal cannot be submitted with undefined observations. Define them or mark them as inactive.".some |
There was a problem hiding this comment.
Is there any use in pointing them to the Overview tab? That is, should we put that bit back? Not suggesting it -- I just don't know the answer.
There was a problem hiding this comment.
I'm going to link to this message in the shortcut story and ask Andy that very question. :) I guess I could do it before merging.
|
I am merging this because I have additional work to do in the same error. I will change the message in a new PR if it needs changed. |
toddburnside
deleted the
sc-4426-do-not-allow-submitting-a-proposal-with-undefined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the UI to match the new limit set in the API.