Fix missing Program tab #4551
Merged
Fix missing Program tab #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (1)
Unchanged files (7)
Total files change -1.03KB -0.04% Final result: ✅ View report in BundleMon website ➡️ |
rpiaggio
reviewed
Feb 10, 2025
| val cfpActivePeriod: Option[DateInterval] = details.proposal.flatMap(_.call).map(_.active) | ||
|
|
||
| // We `should` always have a call for proposal if we get here, but... | ||
| def dateOrMissing(o: Option[LocalDate], label: String) = |
There was a problem hiding this comment.
Maybe we can just omit the element if the date is missing?
Also, could we add explicit types?
There was a problem hiding this comment.
We could do that, but I thought it might be easier to debug in the future if we ever run into this again. It should never happen since the program tab is only for ACCEPTED proposals, which should have a CfP. But, omitting them would be cleaner, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Program tab was not displaying because it required the semester from the call for proposals. We looked up the CfP using the id in the proposal of the program details, but since we were only downloading the
openCfPs, if the proposal specified a CfP whose deadline had passed we wouldn't find it and wouldn't display the tab.I initially just downloaded all the CfP (didn't filter for open in the query) and filtered for
openlocally. Then I realized it was silly to download an ever expanding list of CfPs that we didn't really need, and just downloaded the whole CfP for the proposal instead of just the CfP Id.The first commit just switches to monadic style hooks and cleans up some commented out code. The second is where the real changes are.