Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObsBadge updates #4569

Merged
merged 3 commits into from
Feb 19, 2025
Merged

ObsBadge updates #4569

merged 3 commits into from
Feb 19, 2025

Conversation

toddburnside
Copy link
Contributor

  • [sc-4777] Displays the ObservationReference index in the ObsBadge when it is available, instead of the Observation.Id
  • [sc-4774] Displays the filter and central wavelength in the configuration summary of the ObsBadge. Also changes the string in the configuration selection dropdown in the configuration tile title to match.
  • [sc-3897] For the Data Users table, adds the count of users who have data access in the tile title. Also adds the role column which I omitted by accident.

Copy link

bundlemon bot commented Feb 19, 2025

BundleMon

Files updated (1)
Status Path Size Limits
index-(hash).js
1.75MB (+1.58KB +0.09%) -
Unchanged files (7)
Status Path Size Limits
exploreworkers-(hash).js
597.86KB -
index-(hash).css
66.23KB -
workbox-window.prod.es5-(hash).js
2.07KB -
agsworker-(hash).js
83B -
plotworker-(hash).js
83B -
catalogworker-(hash).js
81B -
itcworker-(hash).js
81B -

Total files change +1.58KB +0.06%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@toddburnside
Copy link
Contributor Author

After discussions with Andy, I changed the name of the Data Users table to Data Sharing and sorted the data for it by Role in Enumerated order so that support users are the bottom by default.

Copy link
Contributor

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddburnside toddburnside merged commit 900c389 into main Feb 19, 2025
14 checks passed
@toddburnside toddburnside deleted the obs-badge-updates branch February 19, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants