Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompute inferred taxon constraints and add to ontology release #19759

Closed
balhoff opened this issue Jul 9, 2020 · 13 comments
Closed

Precompute inferred taxon constraints and add to ontology release #19759

balhoff opened this issue Jul 9, 2020 · 13 comments

Comments

@balhoff
Copy link
Member

balhoff commented Jul 9, 2020

No description provided.

@balhoff balhoff self-assigned this Jul 9, 2020
@cmungall
Copy link
Member

cmungall commented Jul 9, 2020

We can use this to show TCs in amigo, see:

geneontology/amigo#56 geneontology/amigo#58

The requirements are that a class should have a direct lookup to non-redundant only-in and never-in.

E.g for cameraa-type-eye-development we may have

  • only-in vertebrata, from uberon:camera-type-eye
  • only-in metazoa from uberon:generic-eye

We only want to show the more specific one.

similarly never-ins should only be added if they add info on top of the MRCA of only-ins. Note that redundancy checking for never-ins is inverted

Note: this would also be useful for the ontology group, so they can see in Protege the TCs

Things to decide

  • do using OWL reasoning/materialization vs graph walking
  • should this go in robot or a separate util?
  • note for robot, it would be nice if these would show up when we hav inferences in exports, see Add INFERRED as relationship column qualifier for robot export ontodev/robot#697
  • would this be inserted back as a regular owl axiom? What provenance should we add on the axiom? Ideally we could inherit e.g. PMIDs from Uberon TCs but we can tackle this incrementally

@vanaukenk
Copy link
Contributor

vanaukenk commented Jul 9, 2020

See also: geneontology/noctua#261
geneontology/noctua-form#100

for reference to using this information in Noctua either solely for information purposes, or perhaps eventually to prioritize or restrict terms based on the taxon of an annotation entity.

@pgaudet
Copy link
Contributor

pgaudet commented Sep 29, 2020

Hi @balhoff

just wondering where this stands ?

@balhoff
Copy link
Member Author

balhoff commented Oct 1, 2020

I haven't made any progress here; I focused on the Protégé plugin first.

@pgaudet
Copy link
Contributor

pgaudet commented Oct 2, 2020

No problem, just wanted to check.

Thanks, Pascale

@pgaudet
Copy link
Contributor

pgaudet commented Sep 13, 2022

I think this is done @balhoff ?

@ValWood
Copy link
Contributor

ValWood commented Nov 3, 2022

@balhoff ?

@balhoff
Copy link
Member Author

balhoff commented Nov 3, 2022

This is not done. I can try to prioritize this in the next few weeks.

@ValWood
Copy link
Contributor

ValWood commented Nov 3, 2022

OK, should I leave taxon constraint tickets until this is completed?

@balhoff
Copy link
Member Author

balhoff commented Nov 3, 2022

No, this is just a rendering of the logical consequences of all the taxon constraints, for external folks who aren't using an OWL reasoner. So if you add more taxon constraints now, they will still operate within our reasoner-based QC.

@pgaudet
Copy link
Contributor

pgaudet commented Sep 7, 2023

Thanks, I've added this to the next ontology call.

@kltm
Copy link
Member

kltm commented Oct 24, 2023

@pgaudet Unmoved in "PLANNING Phylogeny-based Taxon Constraints"; In Progess in "Ontology technical essentials". Issues should belong in one project, so removing mention in the one that's not being used.

@balhoff
Copy link
Member Author

balhoff commented Oct 28, 2023

Done in #26180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants