Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShEx to use primary input and primary output #309

Open
5 tasks
Tracked by #90
vanaukenk opened this issue Mar 13, 2024 · 1 comment
Open
5 tasks
Tracked by #90

Update ShEx to use primary input and primary output #309

vanaukenk opened this issue Mar 13, 2024 · 1 comment
Assignees

Comments

@vanaukenk
Copy link
Contributor

vanaukenk commented Mar 13, 2024

Modifications to ShEx:

Add:

  • Localization shape - has_primary_input and has_primary_output - NO LONGER NEEDED, AS THIS IS INHERITED FROM THE MAIN BP SHAPE

Remove:

  • PREFIX - transports_or_maintains_localization_of
  • Biological Process shape - transports_or_maintains_localization_of
  • Localization shape: transports_or_maintains_localization_of
  • Transporter Activity shape - transports_or_maintains_localizaton_of

Need to confirm what the implications for removing has_input and has_output will be for the Reactome imports before doing that.

@suzialeksander
Copy link

Bumping this: just noting that right now in Form, the only option is has_primary_i/o, but that annotation then doesn't appear on the annotation preview so at least at SGD, curators are changing it to has_i/o in GE. This is currently affecting other projects than just Reactome as it's what's in Form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants