Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gorule-0000037 : switched back to GO_REF:0000033 #2185

Open
pgaudet opened this issue Nov 21, 2023 · 7 comments
Open

Update gorule-0000037 : switched back to GO_REF:0000033 #2185

pgaudet opened this issue Nov 21, 2023 · 7 comments
Assignees

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Nov 21, 2023

Old rule: IBA annotations should ONLY be assigned_by GO_Central and have PMID:21873635 as a reference

Updated to: "IBA annotations should ONLY be assigned_by GO_Central and have GO_REF:0000033 as a reference

@pgaudet pgaudet self-assigned this Nov 21, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 21, 2023

PR is here: #2186

@LiNiMGI
Copy link
Contributor

LiNiMGI commented Dec 18, 2023

@pgaudet during MGI import project, we found GO_REF:0000033 is listed as GOREF:0000033 in the PAINT files, please update. Thanks, Li

@pgaudet
Copy link
Contributor Author

pgaudet commented Dec 18, 2023

@dustine32 Can you please have a look at that one?

@kltm
Copy link
Member

kltm commented Dec 18, 2023

@pgaudet Which project does this belong to? Or is it "out" as upstream PAINT?

@pgaudet
Copy link
Contributor Author

pgaudet commented Dec 19, 2023

Ah I dont know if it's upstream. We dont have a PAINT project... I put it in Software essential and proactive maintenance, mostly because if the shared resources (@dustine32 )

@LiNiMGI
Copy link
Contributor

LiNiMGI commented Dec 25, 2023

@pgaudet @dustine32
From Lori/MGI: this problem finally also caught up with us at MGI/Production on Dec 17/18 and this affects 68984 annotations.

@dustine32
Copy link
Contributor

Sorry @pgaudet @LiNiMGI, didn't see this until just now! Yes, definitely a (GOREF vs. GO_REF) typo issue though it'll need to be fixed in both (1) the PAINT IBA script and (2) the GO pipeline QC test:

  1. https://github.com/pantherdb/fullgo_paint_update/blob/4b9e560aeb90c049fa9b99ff1a272ee08a2fe983/scripts/createGAF.pl#L451
  2. https://github.com/biolink/ontobio/blob/7e30b36b2c9fbe4f7638d0f2083e2ac6bd0e65c4/ontobio/io/qc.py#L530

I can generate the fixed IBA GAFs. They will then need to make it through a GO release before this fix is seen by MGI.

Also tagging @kltm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants