Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out remaining old goa references (e.g. rna, complex) now that we've switched to goa "plus" files #2341

Open
kltm opened this issue Jul 5, 2024 · 1 comment

Comments

@kltm
Copy link
Member

kltm commented Jul 5, 2024

This is a follow-on from #2214

Basically, in the main pipeline and in the NEO build, there are still from traces of the old metadata. While I don't think it's actually causing any data changes for the moment, I think it would be good to remove any remaining traces, as it is making debugging (possibly related) issues difficult.

@kltm kltm self-assigned this Jul 5, 2024
kltm added a commit to geneontology/pipeline that referenced this issue Jul 5, 2024
@kltm
Copy link
Member Author

kltm commented Jul 5, 2024

@pgaudet I'm trying to clean things out of the metadata that are confusing, as part of a debug process that started with following up on geneontology/noctua#902

In metadata/datasets/goa.yaml, we cleaned out the GAF-related stuff, so that there is only a single file. That fixes things for our downloads and AmiGO.
However, the way that neo builds (for noctua entities) is a little more...abstract. To that end, I think it might be good to:

First, remove all of the GPAD files from goa.yaml, as I don't think we use them and don't see a purpose in having them except creating noise for ourselves.

Second, clarify the contents of the GPI files and see if we want to keep them separate (e.g. goa_dog_complex.gpi.gz /goa_dog_isoform.gpi.gz) or if those can also be unioned into a single file. This will have some consequence in how the NEO build proceeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant