Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistence Date Format for models (sorting problems) #174

Open
tmushayahama opened this issue Mar 13, 2021 · 1 comment
Open

Consistence Date Format for models (sorting problems) #174

tmushayahama opened this issue Mar 13, 2021 · 1 comment

Comments

@tmushayahama
Copy link

Some of the new ZFIN models and imports have a date of format yyyy-m-d without padding i.e. 2020-3-1 and while some created with noctua have format yyyy-mm-dd i.e. 2020-03-01. From sorting point of view, these are different dates since dates are treated as strings in noctua search api. Is it possible to just have same format yyyy-mm-dd Otherwise landing page search will not sort properly for default view (recent models)

As you can see here, by default this is sorted by recent date and March appears recent than September

image

yyyy-m-d format
image

yyyy-mm-dd format
image

tagging @dustine32 @kltm @ukemi @lpalbou @vanaukenk

@dustine32
Copy link
Contributor

Ooo, good catch @tmushayahama! These YYYY-M-D dates are likely all coming from MOD import models, and I just happened to fix this (at @kltm's urging) in the MOD import conversion code. See biolink/ontobio@c862bd2. Though you won't notice the corrections until we regenerate all of the MOD import models. I think these are fixed for MGI and WB, but not yet ZFIN. ZFIN should just be a matter of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants