Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job deletion is recorded in DB before all files deleted #151

Open
abought opened this issue Jul 29, 2024 · 0 comments
Open

Job deletion is recorded in DB before all files deleted #151

abought opened this issue Jul 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@abought
Copy link
Collaborator

abought commented Jul 29, 2024

Summary

While updating parameter handling code, I noticed that the database records a job as being archived before all cleanup is complete. Example:
https://github.com/statgen/cloudgene/blob/950b8b8bd5865482e0114f19f70d17fa83a753bf/src/main/java/cloudgene/mapred/api/v2/admin/ArchiveJob.java#L90-L96

In theory, in the event of a temporary communication failure with external workspace, this could lead to files being retained even after the official records say a file was deleted. This would manifest as significantly higher storage usage in the external workspace. Depending on which files were not deleted, it could also have other implications.

Suggested actions

  • Change the order of instructions so that the DB archive state is only set after all cleanup operations are complete.
  • Audit other delete/archive operations for similar out-of-order behaviors.
@abought abought added the bug Something isn't working label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant