Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wget functionality via external process : error detection needed #29

Open
sheridancbio opened this issue Jul 30, 2016 · 3 comments
Open

Comments

@sheridancbio
Copy link
Collaborator

PdbScriptsPipelineRunCommand.java has code for downloadfile(), but the error detection of failed downloads is not adequate. The return code / exit code of the wget command must be checked. Also the output streams from the process must be handled.

(These problems also occur for other ProcessBuilder use cases)

@sheridancbio
Copy link
Collaborator Author

Just to verify ... do we use wget for the download of ensembl and pdb sequences? Anything else?

@juexinwang
Copy link
Collaborator

Yes, only for these two. nothing else. In Update, I used basic ftp for wget does not work in that ftp server.

@sheridancbio sheridancbio changed the title wget functionality via external process : error detection needed Pri3 : wget functionality via external process : error detection needed Aug 4, 2016
@juexinwang juexinwang changed the title Pri3 : wget functionality via external process : error detection needed Rev3 : wget functionality via external process : error detection needed Aug 10, 2016
@juexinwang
Copy link
Collaborator

Done

@juexinwang juexinwang removed their assignment Aug 10, 2016
@sheridancbio sheridancbio changed the title Rev3 : wget functionality via external process : error detection needed wget functionality via external process : error detection needed Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants