Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PdbScriptsPipelineRunCommand.java is too big #33

Open
sheridancbio opened this issue Jul 30, 2016 · 1 comment
Open

PdbScriptsPipelineRunCommand.java is too big #33

sheridancbio opened this issue Jul 30, 2016 · 1 comment

Comments

@sheridancbio
Copy link
Collaborator

I would separate all the "construct a command" type of functions to a utility class (or classes). I would create separate classes to handle:
- run a local process functions (runwithRedirect)
- downloadfile functionality
- blast processing functions (makedb, blastp)
- gunzip functionality
- ftp file download and parsing
That would leave the main run methods (run, runInit, runUpdatePDB) .. which might also be split up unless they share some common code. The ReadConfig class can/should be used in many places to provide access to the properties.

@juexinwang
Copy link
Collaborator

Yes, I think I have several common functions. I can improve it as you mentioned

@sheridancbio sheridancbio changed the title PdbScriptsPipelineRunCommand.java is too big Pri3 : PdbScriptsPipelineRunCommand.java is too big Aug 4, 2016
@juexinwang juexinwang changed the title Pri3 : PdbScriptsPipelineRunCommand.java is too big Rev3 : PdbScriptsPipelineRunCommand.java is too big Aug 10, 2016
@sheridancbio sheridancbio changed the title Rev3 : PdbScriptsPipelineRunCommand.java is too big PdbScriptsPipelineRunCommand.java is too big Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants