Master html creation with timestamps #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-html Add py script that generates master html
fwa93
requested changes
Feb 11, 2025
…on-with-timestamps Master html creation with timestamps
ryanjameskennedy
force-pushed
the
master-html-creation-with-timestamps
branch
from
4bc8367 to
b8d1ae1
Compare
|
Is there a reason why you run a function in the config just to set a timestamp that is being passed as an argument to a python script? Why not set the timestamp in the python script instead? |
|
|
||
| script: | ||
| """ | ||
| generate_master_html.py --csv ${csv} --html ${params.master_template} --timestamp ${params.trace_timestamp} |
There was a problem hiding this comment.
We could do that but I'm not sure that would solve this problem. That file does exist at that location on out file server. We're not binding /fs1 is all.
ryanjameskennedy
force-pushed
the
master-html-creation-with-timestamps
branch
from
3089059 to
b35c2d3
Compare
The timestamp is a nf-core standard. The timestamp is added into the filename of the nextflow run information html files. So you can't set it later. |
ryanjameskennedy
requested review from
samuell,
mhkc,
ramsainanduri and
svartapaerlan
samuell
requested changes
Feb 18, 2025
samuell
approved these changes
Feb 18, 2025
…-Bioinformatics-Lund/gms_16S into master-html-creation-with-timestamps
ryanjameskennedy
force-pushed
the
master-html-creation-with-timestamps
branch
from
389133c to
61d4699
Compare
ryanjameskennedy
merged commit df9655d
into
genomic-medicine-sweden:dev
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following was added:
master.htmltemplate for jinja py scriptcmd.configfor Lund hospital specificationsgenerate_master_htmlparams.trace_timestamptonextflow.configchangelog_update_reminderGA workflow