Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory leak -03. #406

Open
rachyyyy opened this issue Sep 3, 2022 · 2 comments
Open

Potential memory leak -03. #406

rachyyyy opened this issue Sep 3, 2022 · 2 comments

Comments

@rachyyyy
Copy link

rachyyyy commented Sep 3, 2022

Potential memory leak in kuhl_m_lsadump_dc.c line 1579. The return value of ldap_get_dn is which is szNTDSADn is not freed will cause a memory leak. Doc says "The ldap_get_dn() routine takes an entry as returned by ldap_first_entry(3) or ldap_next_entry(3) and returns a copy of the entry's DN. Space for the DN will be obtained dynamically and should be freed by the caller using ldap_memfree(3). Notes:These routines dynamically allocate memory that the caller must free."

1662196572498

@joshterrill
Copy link

I think this can be addressed just by adding ldap_memfree right after it gets used by szServerDN? I see this pattern showing up in several other places in the code base. I just forked the repo and will do some tests before submitting a PR.

@Lucifer1993
Copy link

Lucifer1993 commented Oct 7, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants