library, docs & test updates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chrstnbwnkl
commented
Jun 7, 2024
chrstnbwnkl
commented
- Updates Python (at least 3.9 required now, 3.8 support was dropped)
- Dependency updates:
- FastAPI
- SQLModel
- Pydantic (major version update, cause of a lot of the changes proposed by the PR)
- linting/formatting
- ruff to replace flake8 (flake8 seems to be behind on some dependency updates anyway)
- Doc updates
- YAML/MD formatting was off
- Valhalla was complaining about GDAL not being found (I guess the base image has it so I just installed it)
- Test updates
- dependency updates broke some of the tests because the error responses changed
chrstnbwnkl
force-pushed
the
cb-update-only
branch
from
5891061 to
0d98a2c
Compare
chrstnbwnkl
commented
Jun 7, 2024
| @@ -73,7 +74,7 @@ def test_job_get_jobs(get_client, basic_auth_header): | |||
| # parameterize the ones that should work with the default params | |||
| @pytest.mark.parametrize( | |||
| "key_value", | |||
| (("bbox", "0,0,1,1"), ("provider", Providers.OSM), ("status", Statuses.QUEUED), ("update", False)), | |||
| (("bbox", "0,0,1,1"), ("provider", "osm"), ("status", "Queued"), ("update", False)), | |||
There was a problem hiding this comment.
Enum strings were turned into their literals for some reason ("Providers.OSM"), better to test with actual strings anyway :)
…ger into cb-temp-dir
configurable tmp dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.