Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Admin::API - Split into two controllers #161

Open
ewlarson opened this issue Oct 8, 2021 · 0 comments
Open

Admin::API - Split into two controllers #161

ewlarson opened this issue Oct 8, 2021 · 0 comments

Comments

@ewlarson
Copy link
Contributor

ewlarson commented Oct 8, 2021

Currently, in api_controller.rb, we're not automatically sending all controller configured facets to Solr. Instead, we're using Solr's solrconfig.xml file to define the list of facets for basic search, and we're using the controller file to define the list of facets for advanced search, many of which have extremely large limit options set.

We should split this one overworked controller into two separate controllers:

  1. Basic Search / api_basic_search_controller.rb
  2. Advanced Search / api_advanced_search_controller.rb

This would allow us to NOT need Solr config changes to update the list of facets for basic search. It would also greatly simplify the configuration of these two files, making "how this works" much easier to understand for other developers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant