Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced Search - Duplicate facet/filter constraints rendered #498

Closed
ewlarson opened this issue Feb 17, 2023 · 2 comments · Fixed by #504
Closed

Advanced Search - Duplicate facet/filter constraints rendered #498

ewlarson opened this issue Feb 17, 2023 · 2 comments · Fixed by #504
Assignees
@ewlarson
Labels
type:bug

Comments

@ewlarson
Copy link
Contributor

Just saw this bug... If you choose advanced search and then toggle a couple of facet options, you'll see those facet search constraints rendered twice in the interface.

Screenshot 2023-02-17 at 4 16 53 PM
@ewlarson
Copy link
Contributor Author

Added to BL Advanced Search: projectblacklight/blacklight_advanced_search#127

@ewlarson
Copy link
Contributor Author

ewlarson commented Mar 4, 2023

My fork'd branch that fixes the issue:
https://github.com/ewlarson/blacklight_advanced_search/tree/bl7-fix-gentle-hands

My open PR with BL Adv Search gem here:
projectblacklight/blacklight_advanced_search#128

Hopefully the BL community accepts my PR, but we should try running the fork'd version next sprint if nothing else.

@ewlarson ewlarson added this to Q1 2023 Mar 14, 2023
ewlarson added a commit that referenced this issue Mar 14, 2023
@ewlarson
Gems: bug fixes
b8cd740 
* Bump GBL Sidecar Images gem to the new v1.0 release
* Pin BL Advanced Search to my PR bug fix branch

See:

Fixes #502
Fixes #498
@ewlarson ewlarson mentioned this issue Mar 14, 2023
Merged
@ewlarson ewlarson moved this to 👀 In review in Q1 2023 Mar 14, 2023
@ewlarson ewlarson moved this from 👀 In review to ✅ Done in Q1 2023 Mar 14, 2023
@ewlarson ewlarson self-assigned this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewlarson ewlarson

Labels
type:bug
Projects
No open projects
Q1 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gems: bug fixes geobtaa/geoportal
1 participant
@ewlarson