-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add console test #501
base: main
Are you sure you want to change the base?
Add console test #501
Conversation
Integration tests report: appsharing.space |
Bot please update snapshots again :) |
Triggering CI after snapshot update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
Thanks :)
please update snapshots |
Mmh. How about juste taking a screenshot of the console, which will be stable 😅 |
Making the layer prints the ID of it! Nothing is stable! These screenshots have it out for me! |
Maybe try taking a screenshot without adding the layer? |
You can fix that by adding a |
.getByRole('textbox') | ||
.filter({ hasText: /^$/ }) | ||
.locator('div') | ||
.fill('doc.add_geojson_layer(path="testDir/eq.json")'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.fill('doc.add_geojson_layer(path="testDir/eq.json")'); | |
.fill('doc.add_geojson_layer(path="testDir/eq.json");'); |
Description
Add a UI test for the embedded console.
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--501.org.readthedocs.build/en/501/
💡 JupyterLite preview: https://jupytergis--501.org.readthedocs.build/en/501/lite