Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DH): Prevent XSS attacks #706

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix(DH): Prevent XSS attacks #706

merged 2 commits into from
Nov 29, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

This PR removes the SafePipe that bypasses angulars sanitization, that prevents JS injection that would execute code.

We think that we implented it in the first place to make the html tags be rendered correctly. But we cannot see any difference of the rendering behaviour without the SafePipe.

This should make the datahub more secure against XSS-Attacks.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search, util-shared, ui-widgets, feature-editor, ui-inputs,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks

@coveralls
Copy link

Coverage Status

coverage: 82.114% (-4.0%) from 86.117%
when pulling baf8723 on DH-fix-xss
into 998c2e2 on main.

@fgravin fgravin merged commit a26286f into main Nov 29, 2023
7 checks passed
@fgravin fgravin deleted the DH-fix-xss branch November 29, 2023 17:41
@jahow jahow added bug Something isn't working and removed backport 2.0.x labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants