Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix E2E flaky tests #708

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Attempt to fix E2E flaky tests #708

merged 1 commit into from
Dec 1, 2023

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Nov 30, 2023

This PR adds a waiting time in the docker composition to make sure that records show up in GN before triggering the rest.

Previously we were only waiting for GN to declare that indexing was finished, but it turns out there can be a few seconds between end of the indexation and the records being visible in the catalog. I suspect that was the cause of the failing tests

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, @jahow, thanks ! I'm not a shell expert, but the idea LGTM and the e2e tests seem to run really well in the CI :-)

@jahow jahow merged commit c1e561c into main Dec 1, 2023
6 checks passed
@jahow jahow deleted the fix-e2e-flaky-tests branch December 1, 2023 10:05
@jahow jahow mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants