Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console fails with java.lang.NumberFormatException: For input string: "${rabbitmqPort}" #336

Closed
jeanpommier opened this issue Oct 2, 2023 · 7 comments

Comments

@jeanpommier
Copy link
Member

With the recent introduction of rabbit MQ, some new config parameters have been introduced in the default.properties file.

Since Rabbit MQ for now only addresses the usage of Gateway, I would say that we should consider it optional, since Gateway is still not the mainstream option. Considering that, it would be good if those config parameters didn't break the apps.

Right now, using the helm chart and docker-master datadir, the console fails with java.lang.NumberFormatException: For input string: "${rabbitmqPort}".

Apparently, the issue is not rabbit MQ not being available, but simply a string to Int conversion error (when RABBITMQ_PORT is not configured). I propose we provide a default value to this env var, to prevent this error. I didn't check it on properties file, but ${RABBITMQ_PORT:-5672} works in the shell and should also work here, I'd say. And at least prevent this error.

@jeanpommier
Copy link
Member Author

jeanpommier commented Oct 17, 2023

Ping rabbitmq guys (@edevosc2c @jeanmi151 ). Any progress on this ?

AFAIK, currently, standard helm chart deployment is broken because of this, and simple docker-compose is broken because of traefik SSL certificate issue. Which means that people wanted to test georchestra using a containerized solution will conclude this is not working and move to something else.

@fvanderbiest
Copy link
Member

simple docker-compose is broken because of traefik SSL certificate issue

Tested working yesterday

@jeanpommier
Copy link
Member Author

OK, but in the long run ?

@edevosc2c
Copy link
Member

@jeanpommier please submit the quick solution that you proposed: ${RABBITMQ_PORT:-5672}

And we will revise the issue later, thank you :). Don't close this github issue.

@jeanpommier
Copy link
Member Author

I'd say "you broke it you fix it", but well, I'll take some time to submit it

@edevosc2c
Copy link
Member

console and gateway just got rabbitmq disabled by default:
georchestra/georchestra#4047
georchestra/georchestra-gateway#62

so it shouldn't look for RABBITMQ_PORT and so on anymore.

@jeanpommier can you still reproduce the issue on georchestra master?

@jeanpommier
Copy link
Member Author

jeanpommier commented Nov 6, 2023

Thanks @edevosc2c. I'm still having trouble with the traefik.me certifictae, but the rabbbitmq errors in console logs are not there anymore, so I'd say this is fixed. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants