Skip to content

Commit 8614c7f

Browse files
authored
Merge pull request #31 from PredokMiF/master
Do not show success message when request failed
2 parents e146215 + 028fe58 commit 8614c7f

File tree

6 files changed

+102
-60
lines changed

6 files changed

+102
-60
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
.idea
12
.DS_Store
23
node_modules
34
npm-debug.log
45
dist
56
uploads
6-
coverage
7+
coverage

lib/components/FileUploadProgress.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,7 @@ FileUploadProgress.defaultProps = {
239239
{ style: { color: '#a94442' } },
240240
'Failed to upload ...'
241241
);
242-
}
243-
if (progress === 100) {
242+
} else if (progress === 100) {
244243
message = _react2.default.createElement(
245244
'span',
246245
null,

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
},
6666
"dependencies": {
6767
"babel-plugin-istanbul": "^4.1.5",
68+
"eslint-plugin-import": "^2.14.0",
6869
"object-assign": "^4.1.0",
6970
"prop-types": "^15.5.10",
7071
"sinon": "^4.2.0"

src/components/FileUploadProgress.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,15 +186,14 @@ FileUploadProgress.defaultProps = {
186186
if (hasError) {
187187
barStyle.backgroundColor = '#d9534f';
188188
message = (<span style={{ color: '#a94442' }}>Failed to upload ...</span>);
189-
}
190-
if (progress === 100) {
189+
} else if (progress === 100) {
191190
message = (<span >Successfully uploaded</span>);
192191
}
193192

194193
return (
195194
<div className="_react_fileupload_progress_content">
196195
<div style={styles.progressWrapper}>
197-
<div className="_react_fileupload_progress_bar" style={barStyle}></div>
196+
<div className="_react_fileupload_progress_bar" style={barStyle}/>
198197
</div>
199198
<button
200199
className="_react_fileupload_progress_cancel"

src/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
import FileUploadProgress from './components/FileUploadProgress';
2+
23
export default FileUploadProgress;

yarn.lock

Lines changed: 95 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,6 @@ ansi-styles@^3.1.0:
186186
dependencies:
187187
color-convert "^1.9.0"
188188

189-
ansi-styles@~1.0.0:
190-
version "1.0.0"
191-
resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-1.0.0.tgz#cb102df1c56f5123eab8b67cd7b98027a0279178"
192-
193189
anymatch@^1.3.0:
194190
version "1.3.2"
195191
resolved "https://registry.yarnpkg.com/anymatch/-/anymatch-1.3.2.tgz#553dcb8f91e3c889845dfdba34c77721b90b9d7a"
@@ -394,7 +390,7 @@ babel-code-frame@^6.22.0, babel-code-frame@^6.26.0:
394390
esutils "^2.0.2"
395391
js-tokens "^3.0.2"
396392

397-
babel-core@^6.1.4, babel-core@^6.14.0, babel-core@^6.26.0:
393+
babel-core@^6.14.0, babel-core@^6.26.0:
398394
version "6.26.0"
399395
resolved "https://registry.yarnpkg.com/babel-core/-/babel-core-6.26.0.tgz#af32f78b31a6fcef119c87b0fd8d9753f03a0bb8"
400396
dependencies:
@@ -1523,14 +1519,6 @@ chalk@^2.0.0, chalk@^2.1.0:
15231519
escape-string-regexp "^1.0.5"
15241520
supports-color "^4.0.0"
15251521

1526-
chalk@~0.4.0:
1527-
version "0.4.0"
1528-
resolved "https://registry.yarnpkg.com/chalk/-/chalk-0.4.0.tgz#5199a3ddcd0c1efe23bc08c1b027b06176e0c64f"
1529-
dependencies:
1530-
ansi-styles "~1.0.0"
1531-
has-color "~0.1.0"
1532-
strip-ansi "~0.1.0"
1533-
15341522
chardet@^0.4.0:
15351523
version "0.4.2"
15361524
resolved "https://registry.yarnpkg.com/chardet/-/chardet-0.4.2.tgz#b5473b33dc97c424e5d98dc87d55d4d8a29c8bf2"
@@ -1710,6 +1698,10 @@ constants-browserify@~1.0.0:
17101698
version "1.0.0"
17111699
resolved "https://registry.yarnpkg.com/constants-browserify/-/constants-browserify-1.0.0.tgz#c20b96d8c617748aaf1c16021760cd27fcb8cb75"
17121700

1701+
contains-path@^0.1.0:
1702+
version "0.1.0"
1703+
resolved "https://registry.yarnpkg.com/contains-path/-/contains-path-0.1.0.tgz#fe8cf184ff6670b6baef01a9d4861a5cbec4120a"
1704+
17131705
17141706
version "0.5.2"
17151707
resolved "https://registry.yarnpkg.com/content-disposition/-/content-disposition-0.5.2.tgz#0cf68bb9ddf5f2be7961c3a85178cb85dba78cb4"
@@ -1844,7 +1836,7 @@ dateformat@^1.0.6:
18441836
get-stdin "^4.0.1"
18451837
meow "^3.3.0"
18461838

1847-
debug@2, [email protected], debug@^2.2.0, debug@^2.6.8, debug@~2.6.4, debug@~2.6.6, debug@~2.6.9:
1839+
debug@2, [email protected], debug@^2.2.0, debug@^2.6.8, debug@^2.6.9, debug@~2.6.4, debug@~2.6.6, debug@~2.6.9:
18481840
version "2.6.9"
18491841
resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.9.tgz#5d128515df134ff327e90a4c93f4e077a536341f"
18501842
dependencies:
@@ -1999,6 +1991,13 @@ diffie-hellman@^5.0.0:
19991991
miller-rabin "^4.0.0"
20001992
randombytes "^2.0.0"
20011993

1994+
1995+
version "1.5.0"
1996+
resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-1.5.0.tgz#379dce730f6166f76cefa4e6707a159b02c5a6fa"
1997+
dependencies:
1998+
esutils "^2.0.2"
1999+
isarray "^1.0.0"
2000+
20022001
doctrine@^2.0.0, doctrine@^2.1.0:
20032002
version "2.1.0"
20042003
resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-2.1.0.tgz#5cd01fc101621b42c4cd7f5d1a66243716d3f39d"
@@ -2154,7 +2153,7 @@ [email protected]:
21542153
optionalDependencies:
21552154
source-map "~0.2.0"
21562155

2157-
[email protected], escodegen@^1.6.1:
2156+
21582157
version "1.9.0"
21592158
resolved "https://registry.yarnpkg.com/escodegen/-/escodegen-1.9.0.tgz#9811a2f265dc1cd3894420ee3717064b632b8852"
21602159
dependencies:
@@ -2177,6 +2176,35 @@ eslint-config-airbnb@^16.1.0:
21772176
dependencies:
21782177
eslint-config-airbnb-base "^12.1.0"
21792178

2179+
eslint-import-resolver-node@^0.3.1:
2180+
version "0.3.2"
2181+
resolved "https://registry.yarnpkg.com/eslint-import-resolver-node/-/eslint-import-resolver-node-0.3.2.tgz#58f15fb839b8d0576ca980413476aab2472db66a"
2182+
dependencies:
2183+
debug "^2.6.9"
2184+
resolve "^1.5.0"
2185+
2186+
eslint-module-utils@^2.2.0:
2187+
version "2.2.0"
2188+
resolved "https://registry.yarnpkg.com/eslint-module-utils/-/eslint-module-utils-2.2.0.tgz#b270362cd88b1a48ad308976ce7fa54e98411746"
2189+
dependencies:
2190+
debug "^2.6.8"
2191+
pkg-dir "^1.0.0"
2192+
2193+
eslint-plugin-import@^2.14.0:
2194+
version "2.14.0"
2195+
resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.14.0.tgz#6b17626d2e3e6ad52cfce8807a845d15e22111a8"
2196+
dependencies:
2197+
contains-path "^0.1.0"
2198+
debug "^2.6.8"
2199+
doctrine "1.5.0"
2200+
eslint-import-resolver-node "^0.3.1"
2201+
eslint-module-utils "^2.2.0"
2202+
has "^1.0.1"
2203+
lodash "^4.17.4"
2204+
minimatch "^3.0.3"
2205+
read-pkg-up "^2.0.0"
2206+
resolve "^1.6.0"
2207+
21802208
eslint-plugin-react@^7.5.1:
21812209
version "7.5.1"
21822210
resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.5.1.tgz#52e56e8d80c810de158859ef07b880d2f56ee30b"
@@ -2250,7 +2278,7 @@ espree@^3.5.2:
22502278
acorn "^5.2.1"
22512279
acorn-jsx "^3.0.0"
22522280

2253-
[email protected], esprima@^2.1.0, esprima@^2.7.1:
2281+
[email protected], esprima@^2.7.1:
22542282
version "2.7.3"
22552283
resolved "https://registry.yarnpkg.com/esprima/-/esprima-2.7.3.tgz#96e3b70d5779f6ad49cd032673d1c312767ba581"
22562284

@@ -2488,7 +2516,7 @@ find-up@^1.0.0:
24882516
path-exists "^2.0.0"
24892517
pinkie-promise "^2.0.0"
24902518

2491-
find-up@^2.1.0:
2519+
find-up@^2.0.0, find-up@^2.1.0:
24922520
version "2.1.0"
24932521
resolved "https://registry.yarnpkg.com/find-up/-/find-up-2.1.0.tgz#45d1b7e506c717ddd482775a2b77920a3c0c57a7"
24942522
dependencies:
@@ -2780,10 +2808,6 @@ has-binary2@~1.0.2:
27802808
dependencies:
27812809
isarray "2.0.1"
27822810

2783-
has-color@~0.1.0:
2784-
version "0.1.7"
2785-
resolved "https://registry.yarnpkg.com/has-color/-/has-color-0.1.7.tgz#67144a5260c34fc3cca677d041daf52fe7b78b2f"
2786-
27872811
27882812
version "1.1.0"
27892813
resolved "https://registry.yarnpkg.com/has-cors/-/has-cors-1.1.0.tgz#5e474793f7ea9843d1bb99c23eef49ff126fff39"
@@ -3221,7 +3245,7 @@ [email protected], isarray@~0.0.1:
32213245
version "0.0.1"
32223246
resolved "https://registry.yarnpkg.com/isarray/-/isarray-0.0.1.tgz#8a18acfca9a8f4177e09abfc6038939b05d1eedf"
32233247

3224-
[email protected], isarray@~1.0.0:
3248+
[email protected], isarray@^1.0.0, isarray@~1.0.0:
32253249
version "1.0.0"
32263250
resolved "https://registry.yarnpkg.com/isarray/-/isarray-1.0.0.tgz#bb935d48582cba168c06834957a54a3e07124f11"
32273251

@@ -3250,20 +3274,6 @@ isomorphic-fetch@^2.1.1:
32503274
node-fetch "^1.0.1"
32513275
whatwg-fetch ">=0.10.0"
32523276

3253-
isparta@^4.0.0:
3254-
version "4.0.0"
3255-
resolved "https://registry.yarnpkg.com/isparta/-/isparta-4.0.0.tgz#1de91996f480b22dcb1aca8510255bae1574446e"
3256-
dependencies:
3257-
babel-core "^6.1.4"
3258-
escodegen "^1.6.1"
3259-
esprima "^2.1.0"
3260-
istanbul "^0.4.0"
3261-
mkdirp "^0.5.0"
3262-
nomnomnomnom "^2.0.0"
3263-
object-assign "^4.0.1"
3264-
source-map "^0.5.0"
3265-
which "^1.0.9"
3266-
32673277
isstream@~0.1.2:
32683278
version "0.1.2"
32693279
resolved "https://registry.yarnpkg.com/isstream/-/isstream-0.1.2.tgz#47e63f7af55afa6f92e1500e690eb8b8529c099a"
@@ -3547,6 +3557,15 @@ load-json-file@^1.0.0:
35473557
pinkie-promise "^2.0.0"
35483558
strip-bom "^2.0.0"
35493559

3560+
load-json-file@^2.0.0:
3561+
version "2.0.0"
3562+
resolved "https://registry.yarnpkg.com/load-json-file/-/load-json-file-2.0.0.tgz#7947e42149af80d696cbf797bcaabcfe1fe29ca8"
3563+
dependencies:
3564+
graceful-fs "^4.1.2"
3565+
parse-json "^2.2.0"
3566+
pify "^2.0.0"
3567+
strip-bom "^3.0.0"
3568+
35503569
loader-utils@^1.0.2:
35513570
version "1.1.0"
35523571
resolved "https://registry.yarnpkg.com/loader-utils/-/loader-utils-1.1.0.tgz#c98aef488bcceda2ffb5e2de646d6a754429f5cd"
@@ -3765,7 +3784,7 @@ minimalistic-crypto-utils@^1.0.0, minimalistic-crypto-utils@^1.0.1:
37653784
version "1.0.1"
37663785
resolved "https://registry.yarnpkg.com/minimalistic-crypto-utils/-/minimalistic-crypto-utils-1.0.1.tgz#f6c00c1c0b082246e5c4d99dfb8c7c083b2b582a"
37673786

3768-
"minimatch@2 || 3", minimatch@^3.0.0, minimatch@^3.0.2, minimatch@^3.0.4:
3787+
"minimatch@2 || 3", minimatch@^3.0.0, minimatch@^3.0.2, minimatch@^3.0.3, minimatch@^3.0.4:
37693788
version "3.0.4"
37703789
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.0.4.tgz#5166e286457f03306064be5497e8dbb0c3d32083"
37713790
dependencies:
@@ -3971,13 +3990,6 @@ nodemailer@^2.5.0:
39713990
nodemailer-smtp-transport "2.7.2"
39723991
socks "1.1.9"
39733992

3974-
nomnomnomnom@^2.0.0:
3975-
version "2.0.1"
3976-
resolved "https://registry.yarnpkg.com/nomnomnomnom/-/nomnomnomnom-2.0.1.tgz#b2239f031c8d04da67e32836e1e3199e12f7a8e2"
3977-
dependencies:
3978-
chalk "~0.4.0"
3979-
underscore "~1.6.0"
3980-
39813993
39823994
version "3.0.6"
39833995
resolved "https://registry.yarnpkg.com/nopt/-/nopt-3.0.6.tgz#c6465dbf08abcd4db359317f79ac68a646b28ff9"
@@ -4268,6 +4280,12 @@ path-type@^1.0.0:
42684280
pify "^2.0.0"
42694281
pinkie-promise "^2.0.0"
42704282

4283+
path-type@^2.0.0:
4284+
version "2.0.0"
4285+
resolved "https://registry.yarnpkg.com/path-type/-/path-type-2.0.0.tgz#f012ccb8415b7096fc2daa1054c3d72389594c73"
4286+
dependencies:
4287+
pify "^2.0.0"
4288+
42714289
pathval@^1.0.0:
42724290
version "1.1.0"
42734291
resolved "https://registry.yarnpkg.com/pathval/-/pathval-1.1.0.tgz#b942e6d4bde653005ef6b71361def8727d0645e0"
@@ -4308,6 +4326,12 @@ pinkie@^2.0.0:
43084326
version "2.0.4"
43094327
resolved "https://registry.yarnpkg.com/pinkie/-/pinkie-2.0.4.tgz#72556b80cfa0d48a974e80e77248e80ed4f7f870"
43104328

4329+
pkg-dir@^1.0.0:
4330+
version "1.0.0"
4331+
resolved "https://registry.yarnpkg.com/pkg-dir/-/pkg-dir-1.0.0.tgz#7a4b508a8d5bb2d629d447056ff4e9c9314cf3d4"
4332+
dependencies:
4333+
find-up "^1.0.0"
4334+
43114335
pkg-dir@^2.0.0:
43124336
version "2.0.0"
43134337
resolved "https://registry.yarnpkg.com/pkg-dir/-/pkg-dir-2.0.0.tgz#f6d5d1109e19d63edf428e0bd57e12777615334b"
@@ -4503,6 +4527,13 @@ read-pkg-up@^1.0.1:
45034527
find-up "^1.0.0"
45044528
read-pkg "^1.0.0"
45054529

4530+
read-pkg-up@^2.0.0:
4531+
version "2.0.0"
4532+
resolved "https://registry.yarnpkg.com/read-pkg-up/-/read-pkg-up-2.0.0.tgz#6b72a8048984e0c41e79510fd5e9fa99b3b549be"
4533+
dependencies:
4534+
find-up "^2.0.0"
4535+
read-pkg "^2.0.0"
4536+
45064537
read-pkg@^1.0.0:
45074538
version "1.1.0"
45084539
resolved "https://registry.yarnpkg.com/read-pkg/-/read-pkg-1.1.0.tgz#f5ffaa5ecd29cb31c0474bca7d756b6bb29e3f28"
@@ -4511,6 +4542,14 @@ read-pkg@^1.0.0:
45114542
normalize-package-data "^2.3.2"
45124543
path-type "^1.0.0"
45134544

4545+
read-pkg@^2.0.0:
4546+
version "2.0.0"
4547+
resolved "https://registry.yarnpkg.com/read-pkg/-/read-pkg-2.0.0.tgz#8ef1c0623c6a6db0dc6713c4bfac46332b2368f8"
4548+
dependencies:
4549+
load-json-file "^2.0.0"
4550+
normalize-package-data "^2.3.2"
4551+
path-type "^2.0.0"
4552+
45144553
45154554
version "1.1.14"
45164555
resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-1.1.14.tgz#7cf4c54ef648e3813084c636dd2079e166c081d9"
@@ -4759,6 +4798,12 @@ resolve@^1.1.3, resolve@^1.1.4, resolve@^1.1.6:
47594798
dependencies:
47604799
path-parse "^1.0.5"
47614800

4801+
resolve@^1.5.0, resolve@^1.6.0:
4802+
version "1.8.1"
4803+
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.8.1.tgz#82f1ec19a423ac1fbd080b0bab06ba36e84a7a26"
4804+
dependencies:
4805+
path-parse "^1.0.5"
4806+
47624807
restore-cursor@^2.0.0:
47634808
version "2.0.0"
47644809
resolved "https://registry.yarnpkg.com/restore-cursor/-/restore-cursor-2.0.0.tgz#9f7ee287f82fd326d4fd162923d62129eee0dfaf"
@@ -5027,7 +5072,7 @@ source-map@^0.4.4:
50275072
dependencies:
50285073
amdefine ">=0.0.4"
50295074

5030-
source-map@^0.5.0, source-map@^0.5.1, source-map@^0.5.6, source-map@~0.5.1, source-map@~0.5.3, source-map@~0.5.6:
5075+
source-map@^0.5.1, source-map@^0.5.6, source-map@~0.5.1, source-map@~0.5.3, source-map@~0.5.6:
50315076
version "0.5.7"
50325077
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc"
50335078

@@ -5166,16 +5211,16 @@ strip-ansi@^4.0.0:
51665211
dependencies:
51675212
ansi-regex "^3.0.0"
51685213

5169-
strip-ansi@~0.1.0:
5170-
version "0.1.1"
5171-
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-0.1.1.tgz#39e8a98d044d150660abe4a6808acf70bb7bc991"
5172-
51735214
strip-bom@^2.0.0:
51745215
version "2.0.0"
51755216
resolved "https://registry.yarnpkg.com/strip-bom/-/strip-bom-2.0.0.tgz#6219a85616520491f35788bdbf1447a99c7e6b0e"
51765217
dependencies:
51775218
is-utf8 "^0.2.0"
51785219

5220+
strip-bom@^3.0.0:
5221+
version "3.0.0"
5222+
resolved "https://registry.yarnpkg.com/strip-bom/-/strip-bom-3.0.0.tgz#2334c18e9c759f7bdd56fdef7e9ae3d588e68ed3"
5223+
51795224
strip-indent@^1.0.1:
51805225
version "1.0.1"
51815226
resolved "https://registry.yarnpkg.com/strip-indent/-/strip-indent-1.0.1.tgz#0c7962a6adefa7bbd4ac366460a638552ae1a0a2"
@@ -5409,10 +5454,6 @@ umd@^3.0.0:
54095454
version "3.0.1"
54105455
resolved "https://registry.yarnpkg.com/umd/-/umd-3.0.1.tgz#8ae556e11011f63c2596708a8837259f01b3d60e"
54115456

5412-
underscore@~1.6.0:
5413-
version "1.6.0"
5414-
resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.6.0.tgz#8b38b10cacdef63337b8b24e4ff86d45aea529a8"
5415-
54165457
underscore@~1.7.0:
54175458
version "1.7.0"
54185459
resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.7.0.tgz#6bbaf0877500d36be34ecaa584e0db9fef035209"
@@ -5516,7 +5557,7 @@ when@^3.7.7:
55165557
version "3.7.8"
55175558
resolved "https://registry.yarnpkg.com/when/-/when-3.7.8.tgz#c7130b6a7ea04693e842cdc9e7a1f2aa39a39f82"
55185559

5519-
which@^1.0.9, which@^1.1.1, which@^1.2.1, which@^1.2.9:
5560+
which@^1.1.1, which@^1.2.1, which@^1.2.9:
55205561
version "1.3.0"
55215562
resolved "https://registry.yarnpkg.com/which/-/which-1.3.0.tgz#ff04bdfc010ee547d780bec38e1ac1c2777d253a"
55225563
dependencies:

0 commit comments

Comments
 (0)