Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud-J v8 #12

Open
lizziel opened this issue Mar 18, 2024 · 3 comments
Open

Cloud-J v8 #12

lizziel opened this issue Mar 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request never stale Do not mark this issue as stale

Comments

@lizziel
Copy link
Contributor

lizziel commented Mar 18, 2024

The main development branch is currently Cloud-J v7.7 from @pratherUCI with some additional updates such as CMake build system. After #2 is merged it will also have no diff updates for compatibility within GEOS-Chem Classic and GCHP, as well as GEOS-Chem within the GEOS and CESM earth system models. I will tag that version v7.7.1.

@pratherUCI has a newer version of Cloud-J that we will put into this repository. He writes:

The next version of Cloud-J standalone is v8.0c, it has been changed (minorly) to include H2O absorption. At the time I also went through all the old commons and removed dead variables (as you did). I will check my list. So how is best to proceed.
BTW, this code enabled me to include NO2 absorption (small effects vs H2O). The major change is in one input table, a few lines of code, and then the clean up. This is not urgent, the only change is the H2O abs.
Prather, Michael (2023). An updated cloud-overlap photolysis module for atmospheric chemistry models, UCI Cloud-J v8.0, with near-UV H2O absorption [Dataset]. Dryad. https://doi.org/10.7280/D1Q398

I believe I have all of the files for v8.0c (@pratherUCI, let me know if they have changed since you posted on Google Drive). The best way to get these into the model would be for me to create a branch off of my original commit, copy in those files, merge in the latest Cloud-J, and create a PR. That should isolate the science differences. There will be merge conflicts but I am familiar enough with the code to resolve them, and can reach out with any questions. I will make @pratherUCI a reviewer to make sure nothing is missed.

There are also several no diff code improvements suggested by @yantosca in his review of #2. These can go into a Z version at any time.

@lizziel lizziel added the enhancement New feature or request label Mar 18, 2024
@lizziel lizziel self-assigned this Mar 18, 2024
Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale label Apr 22, 2024
@yantosca yantosca added never stale Do not mark this issue as stale and removed stale labels Apr 22, 2024
@lizziel
Copy link
Contributor Author

lizziel commented Jul 17, 2024

We will prioritize this update for GEOS-Chem 14.5.

@lizziel
Copy link
Contributor Author

lizziel commented Aug 13, 2024

As part of this update I am adding a run-time option to turn off the application of UV absorption by water vapor. H2O UV absorption is new in Cloud-J v8 and users may want to investigate the effects or decide not to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request never stale Do not mark this issue as stale
Projects
None yet
Development

No branches or pull requests

2 participants