Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose cesium antialiasing parameter via the UI #10572

Open
landryb opened this issue Sep 25, 2024 · 0 comments
Open

expose cesium antialiasing parameter via the UI #10572

landryb opened this issue Sep 25, 2024 · 0 comments
Labels
New Feature used for new functionalities

Comments

@landryb
Copy link
Collaborator

landryb commented Sep 25, 2024

Description

as found out by my colleague working on 3d datasets, cesium has an antialiasing parameter named "msaaSamples" since CesiumGS/cesium#10052, cf CesiumGS/cesium#9900 for the background

according to the cesium docs:

If provided, this value controls the rate of multisample antialiasing. Typical multisampling rates are 2, 4, and sometimes 8 samples per pixel. Higher sampling rates of MSAA may impact performance in exchange for improved visual quality. This value only applies to WebGL2 contexts that support multisample render targets. Set to 1 to disable MSAA.

it provides nice rendering improvements when tested via the map plugin config (eg setting "msaaSamples" inside the "cesium" block), especially on 3d buildings with straight lines

without msaasamples:
image
with msaasamples set to 4
image

Acceptance criteria

it might be interesting to provide a checkbox or a counter in the 3d view configuration to set the parameter, and make it discoverable to users.

@landryb landryb added the New Feature used for new functionalities label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature used for new functionalities
Projects
None yet
Development

No branches or pull requests

1 participant