Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10660: Enhance About plugin to show/hide version/content sections #10661

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mahmoudadel54
Copy link
Contributor

Description

This PR enhances About plugin by adding 2 new cfg props, it includes:

  • 'showAboutContent' to show/hide the content section in About plugin
  • 'showVersionInfo' to show/hide the version info section.
  • They are true value by default.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#10660

What is the new behavior?
If cfg of About plugin, 'showAboutContent' and 'showVersionInfo' can be added with bool values.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Sample of About plugin in localConfig to hide version info section:

{
   "name": "About",
       "cfg": {
           "githubUrl": "https://github.com/geosolutions-it/MapStore2/tree/",
                "showVersionInfo": false
       }
},

Sample of About plugin in localConfig to hide about content section:

{
   "name": "About",
       "cfg": {
           "githubUrl": "https://github.com/geosolutions-it/MapStore2/tree/",
          "showAboutContent": false
    }
},

@mahmoudadel54 mahmoudadel54 linked an issue Nov 8, 2024 that may be closed by this pull request
6 tasks
@tdipisa tdipisa added this to the 2024.02.02 milestone Nov 8, 2024
@tdipisa tdipisa merged commit 7893c7f into geosolutions-it:master Nov 8, 2024
6 checks passed
@tdipisa
Copy link
Member

tdipisa commented Nov 8, 2024

@ElenaGallo please test this in DEV and let us know if we can backport
@mahmoudadel54 once you receive the approval please provide a draft PR to backport to 2024.02.xx. We have to wait 2024.02.01 next week.

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 8, 2024
@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please provide a draft PR to backport to 2024.02.xx.

@mahmoudadel54
Copy link
Contributor Author

Test passed, @mahmoudadel54 please provide a draft PR to backport to 2024.02.xx.

Backport is done ---> #10662

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance About plugin to show/hide version/content sections
4 participants