Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cesium): Add configuration to optionally disable surface collision detection. #10691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdaehnert
Copy link

Description

Cesium offers multiple settings for view behavior. One is to allow zooming below surface. It's needed to view elements under the map itself.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
Zoom on a 3D map can't go below surface. Disabling the collision would require changing the cesium/Map.jsx module fully.

What is the new behavior?
This PR adds an optional flag to disable collision which can be set by customers via localConfig.json setting.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No -> Introducing an optional setting which uses default Cesium value when not set.

Other useful information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant