Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ROIGeometry in place of ROIShape #155

Open
aaime opened this issue Jun 7, 2017 · 2 comments
Open

Use ROIGeometry in place of ROIShape #155

aaime opened this issue Jun 7, 2017 · 2 comments
Assignees
@aaime
Labels
enhancement Priority: High [zube]: Backlog

Comments

@aaime
Copy link
Member

aaime commented Jun 7, 2017 •
edited
Loading

ROIShape rasterizes as a single large image for any operation requiring its raster form (e.g., even just an intersection check if the other ROI is raster), causing memory pressure, replace it with ROIGeometry.
@aaime
Copy link
Member Author

aaime commented Jun 9, 2017

Maybe also add a constructor accepting a Rectangle or a generic Shape, it would make it easier to migrate from ROIShape

@dromagnoli
Copy link
Member

Maybe also add a constructor accepting a Rectangle or a generic Shape, it would make it easier to migrate from ROIShape

Constructor with Rectangle support has been introduced in 2018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaime aaime

Labels
enhancement Priority: High [zube]: Backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aaime @simboss @dromagnoli