Merge pull request #162 from geotrev/develop

Adds stylelint

Author: geotrev

.eslintrc.js

@@ -208,8 +208,5 @@ module.exports = {
     // jsx-a11y
     "jsx-a11y/no-noninteractive-element-interactions": OFF,
     "jsx-a11y/no-interactive-element-to-noninteractive-role": OFF,
-
-    // used for undernet only
-    "no-console": OFF,
   },
 }

app/components/Article/Article.js

@@ -14,14 +14,14 @@ export default function Article(props) {
     COMPONENTS.forEach(Component => Component.stop())
   }
 
-  const onMountOnly = []
+  const observedStateOnMount = []
   useEffect(() => {
     Prism.highlightAll()
     COMPONENTS.forEach(Component => Component.start())
     setDomIsLoaded(true)
 
     return componentUnmountFunction
-  }, onMountOnly)
+  }, observedStateOnMount)
 
   return (
     <article

app/components/Footer/styles.scss

@@ -10,6 +10,6 @@
   .has-feather {
     @include colored-link;
     display: inline-block;
-    padding: 1rem;
+    padding: $global-space;
   }
 }

app/components/GlobalNav/styles.scss

@@ -13,6 +13,10 @@
   padding: 0;
   z-index: 5;
 
+  li {
+    padding: 0;
+  }
+
   .nav-list {
     list-style-type: none;
     margin: 0;
@@ -41,23 +45,19 @@
         list-style-type: none;
         margin: 0;
         padding: 0;
+      }
 
-        li {
-          display: flex;
-          align-items: center;
-        }
+      li {
+        display: flex;
+        align-items: center;
       }
     }
   }
 
-  li {
-    padding: 0;
-  }
-
   li a {
     @include colored-link($white);
     display: flex;
     text-decoration: none;
-    padding: 1rem;
+    padding: $global-space;
   }
 }

app/components/PageHeader/PageHeader.js

@@ -7,15 +7,15 @@ import { FOCUSABLE_TABINDEX, UNFOCUSABLE_TABINDEX } from "./constants"
 const PageHeader = props => {
   const [tabIndex, setTabIndex] = useState(FOCUSABLE_TABINDEX)
   const headerRef = useRef(null)
-  const onMountOnly = []
+  const observedStateOnMount = []
 
   useEffect(() => {
     if (props.lastLocation) {
       headerRef.current.focus()
     } else {
       setTabIndex(UNFOCUSABLE_TABINDEX)
     }
-  }, onMountOnly)
+  }, observedStateOnMount)
 
   const handleBlur = () => {
     if (tabIndex === UNFOCUSABLE_TABINDEX) return

app/components/ScrollUpOnMount/ScrollUpOnMount.js

@@ -1,11 +1,11 @@
 import { useEffect } from "react"
 
 export default function ScrollUpOnMount() {
-  const onMountOnly = []
+  const observedStateOnMount = []
 
   useEffect(() => {
     window.scrollTo(0, 0)
-  }, onMountOnly)
+  }, observedStateOnMount)
 
   return null
 }

app/components/SideNav/SideNav.js

@@ -33,20 +33,20 @@ export default function SideNav() {
     Accordions.stop()
   }
 
-  const onMountOnly = []
+  const observedStateOnMount = []
   useEffect(() => {
     Accordions.start()
     window.addEventListener("resize", handleMenuVisibility)
     setMenuIsOpen(isLargerThanCollapseWidth)
 
     return componentUnmountFunction
-  }, onMountOnly)
+  }, observedStateOnMount)
 
-  const updateConditions = [menuIsOpen]
+  const observedStateOnUpdate = [menuIsOpen]
   useEffect(() => {
     Accordions.stop()
     Accordions.start()
-  }, updateConditions)
+  }, observedStateOnUpdate)
 
   // set up handlers and other helper methods
 

app/components/SideNav/styles.scss

@@ -1,5 +1,7 @@
 @import "app/global";
 
+// stylelint-disable
+
 #side-nav {
   background: #fbfbfb;
 

app/layouts/Main/Main.js

@@ -26,11 +26,11 @@ export default function Main() {
     ContextUtil.disableFocusOutline()
   }
 
-  const onMountOnly = []
+  const observedStateOnMount = []
   useEffect(() => {
     ContextUtil.enableFocusOutline()
     return componentUnmountFunction
-  }, onMountOnly)
+  }, observedStateOnMount)
 
   const handleRefocusClick = ref => {
     ref.current.setAttribute(Attributes.TABINDEX, FOCUSABLE_TABINDEX)

app/layouts/Main/prism.scss

@@ -7,6 +7,9 @@ Prism template by Bram de Haan (http://atelierbram.github.io/syntax-highlighting
 Original Base16 color scheme by Chris Kempson (https://github.com/chriskempson/base16)
 
 */
+
+// stylelint-disable
+
 code[class*="language-"],
 pre[class*="language-"] {
   font-family: Consolas, Menlo, Monaco, "Andale Mono WT", "Andale Mono", "Lucida Console",