Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for List, Set and Map attributes #108

Closed
mbastian opened this issue Jan 20, 2016 · 5 comments
Closed

Add support for List, Set and Map attributes #108

mbastian opened this issue Jan 20, 2016 · 5 comments
Assignees
Milestone

Comments

@mbastian
Copy link
Member

No description provided.

@mbastian mbastian self-assigned this Jan 20, 2016
@mbastian mbastian added this to the 0.5.0 milestone Jan 20, 2016
mbastian added a commit that referenced this issue Jan 20, 2016
@eduramiba
Copy link
Member

I guess we should add consistent printing and parsing for these types too.
Are they able to contain complex object or just simple types?
Are values constrained to a single type or are they any object?

I guess we could use the following syntaxes:

For lists => Same as arrays ([1, 2, 3, 2, 1])
For sets => Same as arrays ([1, 2, 3])
For maps => Similar to interval types? JSON?

@mbastian
Copy link
Member Author

I agree, can you help with this as you're the most familiar with the print/parsing code.

Only simple types are allowed as values of these collections. However, it's allowed to mix different types within a list or a set so I'm not sure how we would proceed for parsing.

@mbastian mbastian reopened this Jan 25, 2016
@eduramiba
Copy link
Member

Yeah I was thinking to do it myself.
Does JSON sound right? It can be convenient to users.

If the value type is not known, I guess we should infer it for each value to a few types: null, String, long (BigInteger if too big) or double (BigDecimal if too big).

Same for the key or only Strings are allowed?

@mbastian
Copy link
Member Author

mbastian commented Feb 3, 2016

I finally restricted the lists to a unique type, no mixed types. For maps, keys should only be simple types (Double, Float, Long, Int, Boolean, String etc.)

I'm gonna create another issue btw about print/parse and close this one.

@eduramiba
Copy link
Member

Great, I will assign #117 to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants