Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker sometimes chooses 2 identical colours #63

Open
RandomUsernameThatIsNotYetTaken opened this issue Nov 5, 2022 · 4 comments

Comments

@RandomUsernameThatIsNotYetTaken

20221105_080759

See attached image, there are 2 separate parts in (almost) identical green colour.

Seems the randomisation screwed up?

@gereleth
Copy link
Owner

gereleth commented Nov 5, 2022

Well the random color is just that - random. It doesn't check if similar colors are present on the board. So this happens sometimes. Bad luck =).

I can leave this issue open in case someone wants to improve the logic of color selection.
But personally I can live with how it is =).

@RandomUsernameThatIsNotYetTaken
Copy link
Author

@gereleth I'll try and create a PR for this then.
For something I start my day with everyday, I might as wel start helping out.

@Jaybrainer
Copy link

Jaybrainer commented Feb 4, 2023

Can resolve this by assigning an incrementing ID to each group of connected pipes. Colours can then be assigned based off of the ID, with sufficient colours for expected IDs. Also can eliminate colouring single cell groups after a rotation, as this doesn't aid the solve, and will take up colours for other groups.
A separate approach could be to only highlight the previously interacted group (this could just be an additional setting too if wanted).

@mtmail
Copy link

mtmail commented Apr 16, 2023

Another example I saw today
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants