Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimp3 causes iOS app store rejection due to slice_deque use #39

Open
alice-i-cecile opened this issue Nov 18, 2021 · 4 comments
Open

Comments

@alice-i-cecile
Copy link

Heads up, using the mp3 Bevy feature will cause your iOS app to get rejected because minimp3 depends on slice_deque which uses an internal API for memory allocation.

First reported in bevyengine/bevy#3145. minimp3-rs is a doubly-transitive dependency of ours.

The dependency that you're using here seems to be unmaintained, so migrating away is likely the only real solution.

@LiquidityC
Copy link

This is more or less a duplicate of #29

@ArthurKValladares
Copy link

I don't think these are exactly the same issues. My app is getting rejected because we are referencing the non-public symbols: _mach_vm_allocate, _mach_vm_deallocate, _mach_vm_remap .

These are still being referenced in the slice_ring_buffer fork, so I think this is a different issue from the security issue fixed by your fork.

@LiquidityC
Copy link

Oh. Perhaps that is the case. Can you provide a more detailed error and perhaps drop me an issue and I'll check if it's something I can fix.

@ArthurKValladares
Copy link

I very weirdly opened a PR for in your fork of this repo (I don't know what I was thinking either) that fixes and explains the issue a bit better:
https://github.com/LiquidityC/minimp3-rs/pull/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants