-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET webhooks/:webhookId/:webhookToken/messages/:msgId always returns 404 #19
Comments
I'm not sure what other webhook endpoints are affected, but DELETE webhook message is too |
|
@Larsundso I think you can reopen the issue because you found a bug. I can repro reliably by trying to get a message that don't/no longer exists. Repro steps:
The issue likely lies here: Lines 351 to 358 in 23fc2e7
It should additionally check if the body code is 10015 (Unknown webhook). I looked to make a PR but I'm not sure how to parse the body and I'm not a go dev :( |
How to reproduce:
Possible prerequisites
Every time i restarted the docker image it would work for 5-10 seconds before returning 404 again
The error description would be "No Description"
I encountered this only after releasing a Feature that would utilize several hundred webhooks sending several thousand requests per minute combined
The text was updated successfully, but these errors were encountered: