From 4c46b2ff87ddc25cbbf7ee1b06453b3d031f403a Mon Sep 17 00:00:00 2001
From: Caitlin Elfring <celfring@gmail.com>
Date: Wed, 21 Jul 2021 19:13:10 -0400
Subject: [PATCH] bug: Add back case insensitivity to rule regex (#110)

* Add case sensitive test

* Add back case insensitive to regex
---
 pkg/rule/rule.go      |  1 +
 pkg/rule/rule_test.go | 13 +++++++------
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/pkg/rule/rule.go b/pkg/rule/rule.go
index ec4f1914..0231a272 100644
--- a/pkg/rule/rule.go
+++ b/pkg/rule/rule.go
@@ -89,6 +89,7 @@ func (r *Rule) setRegex() {
 func (r *Rule) regexString() string {
 	regex := func(start, end string) string {
 		s := strings.Builder{}
+		s.WriteString("(?i)")
 		s.WriteString(start)
 		s.WriteString("(%s)")
 		s.WriteString(end)
diff --git a/pkg/rule/rule_test.go b/pkg/rule/rule_test.go
index 39910651..ad7bce88 100644
--- a/pkg/rule/rule_test.go
+++ b/pkg/rule/rule_test.go
@@ -31,6 +31,7 @@ func TestRule_FindMatchIndexes(t *testing.T) {
 		{"this string has rule-2 and rule1 included", [][]int{{27, 32}}, [][]int{{27, 32}}},
 		{"this string does not have any findings", [][]int(nil), [][]int(nil)},
 		{"this string has finding with word boundary rule1rule-1", [][]int{{43, 48}, {48, 54}}, [][]int(nil)},
+		{"this string has finding with word boundary Rule1rule-1", [][]int{{43, 48}, {48, 54}}, [][]int(nil)},
 	}
 	for _, test := range tests {
 		r := testRule()
@@ -125,33 +126,33 @@ func TestRule_regexString(t *testing.T) {
 		{
 			desc:     "default",
 			rule:     testRule(),
-			expected: `(%s)`,
+			expected: `(?i)(%s)`,
 		},
 		{
 			desc:     "word boundary",
 			rule:     testRuleWithOptions(Options{WordBoundary: true}),
-			expected: `\b(%s)\b`,
+			expected: `(?i)\b(%s)\b`,
 		},
 		{
 			desc:     "word boundary start",
 			rule:     testRuleWithOptions(Options{WordBoundaryStart: true}),
-			expected: `\b(%s)`,
+			expected: `(?i)\b(%s)`,
 		},
 		{
 			desc:     "word boundary end",
 			rule:     testRuleWithOptions(Options{WordBoundaryEnd: true}),
-			expected: `(%s)\b`,
+			expected: `(?i)(%s)\b`,
 		},
 		{
 			desc:     "word boundary start and end",
 			rule:     testRuleWithOptions(Options{WordBoundaryStart: true, WordBoundaryEnd: true}),
-			expected: `\b(%s)\b`,
+			expected: `(?i)\b(%s)\b`,
 		},
 		{
 			// To show that enabling WordBoundary will win over other options
 			desc:     "word boundary and word boundary start/end false",
 			rule:     testRuleWithOptions(Options{WordBoundary: true, WordBoundaryStart: false, WordBoundaryEnd: false}),
-			expected: `\b(%s)\b`,
+			expected: `(?i)\b(%s)\b`,
 		},
 	}
 	for _, tt := range tests {