Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not continue with protocol after X time #2216

Open
bonomat opened this issue Mar 12, 2024 · 3 comments
Open

Do not continue with protocol after X time #2216

bonomat opened this issue Mar 12, 2024 · 3 comments
Labels
bug Something isn't working technical-debt

Comments

@bonomat
Copy link
Contributor

bonomat commented Mar 12, 2024

It looks like the user was just stuck in SettleOffer for quite some time. The user finished the settle protocol on Sunday, 10th of March. Meaning the user wasn't actually stuck, he only withhold the response (SettleAccept) for over a week, which is weird, as the app would reject any pending offer on reconnect. But in this scenario the SettleAccept was eventually sent completing the protocol.

In this case, we should not continue with the protocol.

@bonomat bonomat added bug Something isn't working technical-debt labels Mar 28, 2024
@bonomat
Copy link
Contributor Author

bonomat commented Mar 28, 2024

We disabled force-closure of stuck protocols during beta and we might want to revisit this when going out of beta.

Maybe there is a way of rolling back instead of force-closing.

@Restioson
Copy link
Contributor

In this case, we should not continue with the protocol.

Do you mean that if SettleAccept is late (past X time from last protocol message),then it should not be accepted, whereas now we are accepting it?

@bonomat
Copy link
Contributor Author

bonomat commented Jun 3, 2024

Yes, correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical-debt
Projects
None yet
Development

No branches or pull requests

2 participants