Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit orders #2510

Closed
bonomat opened this issue May 8, 2024 · 4 comments
Closed

Limit orders #2510

bonomat opened this issue May 8, 2024 · 4 comments

Comments

@bonomat
Copy link
Contributor

bonomat commented May 8, 2024

Related to #2171

@bonomat bonomat added the feature label May 8, 2024
@bonomat
Copy link
Contributor Author

bonomat commented May 8, 2024

To be fleshed out.

Some thoughts: the user needs to be online to execute the limit order.

@bonomat
Copy link
Contributor Author

bonomat commented May 9, 2024

Notes on limit orders:

A limit order executes at the specific price set by the trader or a better price if available in the orderbook, meaning, there are two scenarios:

  1. If the limit order is not immediately executed, then the trader pays the maker's order matching fee, once a match is found
  2. If there is already a better price in the orderbook, then the limit order executes at the best price and the trader pays the taker's order matching fee

In some exchanges, it is common to have a post only limit order:
Post-only limit orders are orders where traders specify a limit price but only want their order to be added to the orderbook and not executed immediately. If the order would execute immediately, it's typically rejected.

@holzeis
Copy link
Contributor

holzeis commented May 10, 2024

depends on #2270

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants