Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve linking #129

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: improve linking #129

wants to merge 7 commits into from
+113 −98

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Sep 17, 2024 •
edited
Loading

Improves scheme handling

Improvements

Testing (and for future reference)

To simulate opens during development:

npx uri-scheme open exp://127.0.0.1:8081/--/[LIGHTNING_ADDRESS] --android
npx uri-scheme open exp://127.0.0.1:8081/--/[LNURL] --android
npx uri-scheme open exp://127.0.0.1:8081/--/[BOLT11INVOICE] --android

@reneaaron reneaaron force-pushed the fix/improve-linking branch 2 times, most recently from f3bfe90 to ac12662 Compare September 17, 2024 18:34
@reneaaron reneaaron added this to the 1.5 milestone Sep 17, 2024
reneaaron
reneaaron commented Sep 18, 2024
View reviewed changes
hooks/useHandleLinking.ts Outdated Show resolved Hide resolved
reneaaron
reneaaron commented Sep 18, 2024
View reviewed changes
hooks/useHandleLinking.ts Outdated Show resolved Hide resolved
@reneaaron reneaaron marked this pull request as ready for review September 25, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz Awaiting requested review from rolznz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

lightning: and LNURL are being shown on the confirm payment and success pages when they should not
1 participant
@reneaaron