Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle missing permissions / methods #172

Open
rolznz opened this issue Oct 29, 2024 · 1 comment
Open

Gracefully handle missing permissions / methods #172

rolznz opened this issue Oct 29, 2024 · 1 comment

Comments

@rolznz
Copy link
Contributor

rolznz commented Oct 29, 2024

Currently we do not allow a user to create a wallet if it has missing permissions.

e.g. if list_transactions is not supported, only show an error on the transactions list that "List Transactions is not supported by your wallet.".
e.g. if pay_invoice is not supported, only fail when attempting to make a payment. This allows for receive-only wallets.

@im-adithya
Copy link
Member

But what should be the hard requirements? get_balance and one of make_invoice / pay_invoice?

And what is better:

  • Greying out the Send button (or)
  • Showing error toast when trying to attempt a payment (Showing This app does not have the pay_invoice scope error)

And similarly hardcoding a "This wallet doesn't support listing transactions" over showing error

I personally feel showing less errors is better, but that would mean writing if/else code for these cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants