fix: error handling #101
Merged
fix: error handling #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously we do not properly catch errors in the swr methods. errorToast also threw an uncaught exception if it did not receive an error, which lead to the app hanging
reneaaron
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
@rolznz Do we need to upgrade to some newer GH action here?
https://github.com/getAlby/go/actions/runs/10787033940/job/29914952304?pr=101
utACK
|
@reneaaron the actions fix was merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we do not properly catch errors in the swr methods so we could not show an error toast when something went wrong.
errorToast also threw an uncaught exception if it did not receive an error object, which lead to the app hanging