Bug: Missing node name/ID in pending channel closure alert

[rolznz]

[im-adithya]

I think this happens when there is a PendingSweepBalance because then we don't add the pendingBalancesDetails

hub/lnclient/ldk/ldk.go

Lines 1066 to 1075 in 73540ef

	for _, balance := range balances.PendingBalancesFromChannelClosures {
	switch pendingType := (balance).(type) {
	case ldk_node.PendingSweepBalancePendingBroadcast:
	pendingBalancesFromChannelClosures += pendingType.AmountSatoshis
	case ldk_node.PendingSweepBalanceBroadcastAwaitingConfirmation:
	pendingBalancesFromChannelClosures += pendingType.AmountSatoshis
	case ldk_node.PendingSweepBalanceAwaitingThresholdConfirmations:
	pendingBalancesFromChannelClosures += pendingType.AmountSatoshis
	}
	}

I think it's best to skip when pendingBalancesDetails is empty since by then the channel is properly closed and is not listed in ListChannels response so we don't even fetch the remote node's info to display the alias (and we only have the channel id (see PendingSweepBalance docs) so I'm not sure if we can even fetch the node pubkey using it)

[rolznz]

@im-adithya thanks for looking into it! I don't agree though - if the funds are not swept yet then there are no incoming funds that we can show next to the onchain balance. ListChannels only returns channels which have no closure initiated yet.

@rdmitr are you able to see if it's possible to include some additional fields in balances.PendingBalancesFromChannelClosures such as the CounterpartyNodeId, FundingTxId and FundingTxIndex similar to what you did in getAlby/ldk-node#60? in Alby Hub as Adithya linked above, we handle those ones differently.

[rdmitr]

Yep, I'll look into this!