Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting TLV 34349334 (basic text message) for keysend payments (like Amboss keysend billboard) #32

Open
rolznz opened this issue Jun 14, 2024 · 0 comments

Comments

@rolznz
Copy link

rolznz commented Jun 14, 2024

2024-06-13 08:50:14 INFO  [lightning::ln::channelmanager:6339] Rejecting payment with payment hash 99de4b98ce8d3c7503a254be471bfe8ce802486abfddd5643a57af4302a2aa38 as we cannot accept payment with unknown even TLVs: [34349334]

From tnull:

You'll need to use https://docs.rs/lightning/latest/lightning/ln/channelmanager/struct.ChannelManager.html#method.claim_funds_with_known_custom_tlvs
ChannelManager in lightning::ln::channelmanager - Rust
A lightning node’s channel state machine and payment management logic, which facilitates sending, forwarding, and receiving payments through lightning channels. Instead of claim_fund in your custom TLV implementation.

I think we can maintain a whitelist (just 34349334) and use claim_funds_with_known_custom_tlvs if a TLV matches our whitelist and we understand all the even-numbered TLVs in the payment.

@rolznz rolznz changed the title Consider supporting TLV 34349334 (basic text message) for keysend payments Consider supporting TLV 34349334 (basic text message) for keysend payments (like Amboss keysend billboard) Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant