Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap "accounts" for "wallets" copy #2872

Closed
Tracked by #2871
stackingsaunter opened this issue Nov 16, 2023 · 10 comments
Closed
Tracked by #2871

Swap "accounts" for "wallets" copy #2872

stackingsaunter opened this issue Nov 16, 2023 · 10 comments
Assignees
Labels
frontend All things frontend development related good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Nov 16, 2023

Part of #2871 epic, which full desired effect can be viewed in this Figma

Goal is to change copy related to "extension accounts" that from now on will be called "wallets".

List of changes:

Dropdowns

  • "Settings" --> "Extension Settings"
  • "Account settings" --> "Wallet Settings"
  • "Add an account" --> "Connect a Wallet"
  • "Manage accounts" --> "Manage Wallets
  • "Switch account" --> "Switch Wallet"

image

"Settings" page

  • Page title changes to "Extensions Settings"

"Account settings" page

  • Page title changes to "Wallet Settings"

"Accounts" (Manage accounts)

  • Title changes to "Wallets"
  • Button copy changes to "Connect a Wallet"

CleanShot 2023-11-16 at 21 18 42@2x

@ayushdhiman-py
Copy link

ayushdhiman-py commented Nov 17, 2023

@stackingsaunter Could you please provide path details of the files that need to be changed? It would be really helpful.

@rolznz
Copy link
Contributor

rolznz commented Nov 18, 2023

@ayushdhiman-py this is part of the task to figure that out and make the changes.

@Harshit-Prasad
Copy link

Harshit-Prasad commented Nov 18, 2023

@stackingsaunter I went through the figma files and reviewed all the required changes, I will immediately start working on the issue once I finish setting it up.

@Harshit-Prasad
Copy link

@stackingsaunter sorry but i won't be continuing the issue, thank you as I got to learn about react-i18n. Also this was my first time working on an extension.

@rolznz
Copy link
Contributor

rolznz commented Nov 20, 2023

@Harshit-Prasad thanks for you work. I don't think the translations are an issue here and we can remove the outdated keys of the other languages by running a script.

@AdarshRawat1
Copy link
Contributor

@rolznz I'll be taking on this issue.

@stackingsaunter
Copy link
Contributor Author

@AdarshRawat1 forgot to mention this in initial post

On Wallet Settings page in "Danger" zone copy also must be updated to wallets:

CleanShot 2023-12-01 at 12 07 49@2x

@AdarshRawat1
Copy link
Contributor

On Wallet Settings page in "Danger" zone copy also must be updated to wallets:

@stackingsaunter noted !!

@amitamrutiya
Copy link
Contributor

@stackingsaunter, if this issue is still valid, I would like to work on it.

I noticed that in the wallet setting screen, we still use the account name in some places, such as:

  • "Danger Zone"
  • "Back up your master key description"

@reneaaron
Copy link
Contributor

@amitamrutiya2210 Good point, I just revisited the translations file and found 50 mentions of account. Feel free to revisit those occurrences and update them. (please don't just search & replace but go trough them as the context matters quite a bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend All things frontend development related good first issue Good for newcomers
Projects
None yet
7 participants