Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Extension Settings layout #2874

Closed
Tracked by #2871
stackingsaunter opened this issue Nov 16, 2023 · 8 comments · Fixed by #3069
Closed
Tracked by #2871

Updates to Extension Settings layout #2874

stackingsaunter opened this issue Nov 16, 2023 · 8 comments · Fixed by #3069
Assignees
Labels
frontend All things frontend development related good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

Part of #2871 epic, which full desired effect can be viewed in this Figma

CleanShot 2023-11-16 at 22 50 44@2x

Changes:

  • Page tile contains a description "Global settings that affect your experience on all connected wallets in - Alby Extension.". Space between title and descriptions should be 4px.

  • Section headers are text-xl/bold

  • All buttons and dropdowns should have fixed 256px width

  • Use Title case in all list item labels and buttons

  • Delete Nostr section

  • Delete legacy section

@AdarshRawat1
Copy link
Contributor

@stackingsaunter I got it.

  • Delete Nostr section
  • Delete legacy section

Are we removing the whole section?( settings part )

@stackingsaunter
Copy link
Contributor Author

@AdarshRawat1 yes, whole UI parts of the section.

@amitamrutiya
Copy link
Contributor

Hey @AdarshRawat1, are you still working on this issue? If not, then @stackingsaunter, I would like to try tackling this good first issue.

@AdarshRawat1
Copy link
Contributor

This one totally slipped my mind. 🤧

@amitamrutiya2210 if you wish to start contributing to Alby, you can start with this good first issue.

@amitamrutiya
Copy link
Contributor

Thanks @AdarshRawat1, for replying. I will work on this issue then.

@amitamrutiya
Copy link
Contributor

amitamrutiya commented Mar 6, 2024

Hey @stackingsaunter,

I think some of your suggested changes have already been addressed or removed in the current codebase, such as:

  • The subtitle "Global settings that affect your experience on all connected wallets in - Alby Extension" is not present.
  • The heading for the General section is missing.
  • All buttons and dropdowns have a fixed width of 256px.
  • There is no "Nostr" section.

Here are the things I need to do:

  • Delete the legacy section.
  • Use Title Case in all list item labels and buttons as suggested in figma file.

Is there anything you want to suggest?

@AdarshRawat1
Copy link
Contributor

AdarshRawat1 commented Mar 6, 2024

I think there is some confusion.

  • The subtitle "Global settings that affect your experience on all connected wallets in - Alby Extension" is not present.

Is there anything you want to suggest?

You have to add the subtitle as it is not present currently.

Check the final design in this Figma file and make changes accordingly. ( The points listed in issue description are there to help you find the changes to be made i.e. the difference between current design and desired design.)

@amitamrutiya
Copy link
Contributor

Okay, I overthought this issue. Now I understand it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend All things frontend development related good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants