From 0e3f96273a7f2543dcdff245ce13bbdfdeb23745 Mon Sep 17 00:00:00 2001 From: Rithvik-padma Date: Sat, 23 Dec 2023 06:30:59 +0530 Subject: [PATCH 1/9] feat: removing carets --- src/app/components/AccountMenu/index.tsx | 2 +- src/app/components/BalanceBox/index.tsx | 2 +- src/app/screens/Home/DefaultView/index.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/components/AccountMenu/index.tsx b/src/app/components/AccountMenu/index.tsx index 83e9c46dd5..8b28b8ef8f 100644 --- a/src/app/components/AccountMenu/index.tsx +++ b/src/app/components/AccountMenu/index.tsx @@ -58,7 +58,7 @@ function AccountMenu({ showOptions = true }: Props) { } return ( -
+
diff --git a/src/app/components/BalanceBox/index.tsx b/src/app/components/BalanceBox/index.tsx index a4f59bbf20..f3c1cdd5f6 100644 --- a/src/app/components/BalanceBox/index.tsx +++ b/src/app/components/BalanceBox/index.tsx @@ -13,7 +13,7 @@ function BalanceBox({ className }: Props) { return (
diff --git a/src/app/screens/Home/DefaultView/index.tsx b/src/app/screens/Home/DefaultView/index.tsx index 1f7380cb5e..6d7fefa0e0 100644 --- a/src/app/screens/Home/DefaultView/index.tsx +++ b/src/app/screens/Home/DefaultView/index.tsx @@ -89,7 +89,7 @@ const DefaultView: FC = (props) => { } return ( -
+
{props.renderPublisherWidget && !!props.lnDataFromCurrentTab?.length && ( )} From 81b468789dc1f54e1a9b8a65bf2a2d0cfaa86fe8 Mon Sep 17 00:00:00 2001 From: Rithvik-padma Date: Sat, 23 Dec 2023 07:19:35 +0530 Subject: [PATCH 2/9] feat: add balance box to screen reader --- src/app/components/BalanceBox/index.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/app/components/BalanceBox/index.tsx b/src/app/components/BalanceBox/index.tsx index f3c1cdd5f6..2df71ad88f 100644 --- a/src/app/components/BalanceBox/index.tsx +++ b/src/app/components/BalanceBox/index.tsx @@ -1,4 +1,5 @@ import SkeletonLoader from "@components/SkeletonLoader"; +import { useTranslation } from "react-i18next"; import { useAccount } from "~/app/context/AccountContext"; import { classNames } from "~/app/utils"; @@ -9,9 +10,11 @@ type Props = { function BalanceBox({ className }: Props) { const { balancesDecorated, accountLoading } = useAccount(); const balanceParts = balancesDecorated.accountBalance.split(" "); + const { t: tCommon } = useTranslation("common"); return (
) : ( <> + {tCommon("balance")} {balanceParts[0]}  {balanceParts[1]} From 9e1140015e4ad035f8358dc6d725c2992eee8de6 Mon Sep 17 00:00:00 2001 From: Rithvik-padma Date: Sat, 23 Dec 2023 07:50:01 +0530 Subject: [PATCH 3/9] feat: add transactions to screen reader --- src/app/components/TransactionsTable/TransactionModal.tsx | 2 +- src/app/components/TransactionsTable/index.tsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/app/components/TransactionsTable/TransactionModal.tsx b/src/app/components/TransactionsTable/TransactionModal.tsx index 73aed0a54d..e7928ae77b 100644 --- a/src/app/components/TransactionsTable/TransactionModal.tsx +++ b/src/app/components/TransactionsTable/TransactionModal.tsx @@ -54,7 +54,7 @@ export default function TransactionModal({ contentLabel={"Transactions"} position="top" > -
+
{getTransactionType(transaction) == "outgoing" ? ( diff --git a/src/app/components/TransactionsTable/index.tsx b/src/app/components/TransactionsTable/index.tsx index a9ac5a8f7e..5f6a9b689b 100644 --- a/src/app/components/TransactionsTable/index.tsx +++ b/src/app/components/TransactionsTable/index.tsx @@ -54,6 +54,7 @@ export default function TransactionsTable({ return (
openDetails(tx)} From 88f9a3f80bc7536b208c8e96ff089c1e4e0c930d Mon Sep 17 00:00:00 2001 From: Rithvik-padma Date: Sat, 23 Dec 2023 08:00:04 +0530 Subject: [PATCH 4/9] feat: add see all transactions link to screen reader and make it acessible with enter key --- src/app/screens/Home/DefaultView/index.tsx | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/app/screens/Home/DefaultView/index.tsx b/src/app/screens/Home/DefaultView/index.tsx index 6d7fefa0e0..aefe260923 100644 --- a/src/app/screens/Home/DefaultView/index.tsx +++ b/src/app/screens/Home/DefaultView/index.tsx @@ -4,7 +4,7 @@ import Loading from "@components/Loading"; import TransactionsTable from "@components/TransactionsTable"; import dayjs from "dayjs"; import relativeTime from "dayjs/plugin/relativeTime"; -import { FC, useEffect, useState } from "react"; +import { FC, KeyboardEvent, useEffect, useState } from "react"; import { useTranslation } from "react-i18next"; import { useNavigate } from "react-router-dom"; import BalanceBox from "~/app/components/BalanceBox"; @@ -171,7 +171,15 @@ const DefaultView: FC = (props) => { /> {!isLoading && transactions.length > 0 && ( -
+
{ + if (e.key === "Enter") { + handleViewAllLink("/transactions"); + } + }} + > handleViewAllLink("/transactions")} className="flex justify-center items-center mt-2" From 8c86ad6031382f1a59a97641faf5db7b1854fd4a Mon Sep 17 00:00:00 2001 From: Rithvik-padma Date: Sat, 23 Dec 2023 10:56:27 +0530 Subject: [PATCH 5/9] feat: add screen readers labels in the receive invoice screen --- src/app/components/Header/index.tsx | 4 +++- src/app/screens/Receive/index.tsx | 2 +- src/app/screens/ReceiveInvoice/index.tsx | 6 +++++- src/i18n/locales/en/translation.json | 1 + 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/app/components/Header/index.tsx b/src/app/components/Header/index.tsx index 5d3c0ade01..4939e29cf6 100644 --- a/src/app/components/Header/index.tsx +++ b/src/app/components/Header/index.tsx @@ -9,7 +9,9 @@ function Header({ children, headerLeft, headerRight }: Props) {
{headerLeft}
-

{children}

+

+ {children} +

{headerRight}
diff --git a/src/app/screens/Receive/index.tsx b/src/app/screens/Receive/index.tsx index 9558692df9..7c1cf1230c 100644 --- a/src/app/screens/Receive/index.tsx +++ b/src/app/screens/Receive/index.tsx @@ -70,7 +70,7 @@ function Receive() {
<>
-
+
{loadingLightningAddress ? ( ) : ( diff --git a/src/app/screens/ReceiveInvoice/index.tsx b/src/app/screens/ReceiveInvoice/index.tsx index 02242e8e2c..6d5d74fa7f 100644 --- a/src/app/screens/ReceiveInvoice/index.tsx +++ b/src/app/screens/ReceiveInvoice/index.tsx @@ -142,7 +142,11 @@ function ReceiveInvoice() { {!paid && ( <>
-
+
+ {t("qrcode_invoice")} Date: Sat, 23 Dec 2023 11:09:57 +0530 Subject: [PATCH 6/9] feat: add screen reader labels to the success screen --- src/app/components/ResultCard/index.tsx | 5 ++++- src/app/screens/LNURLPay/index.tsx | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/app/components/ResultCard/index.tsx b/src/app/components/ResultCard/index.tsx index fea7bb78bb..fe21cd68fb 100644 --- a/src/app/components/ResultCard/index.tsx +++ b/src/app/components/ResultCard/index.tsx @@ -5,7 +5,10 @@ export type Props = { export default function ResultCard({ message, isSuccess }: Props) { return ( -
+
{isSuccess {isMessage && ( -
+
{descriptionList.map(([dt, dd]) => ( <>
{dt}
From 1004c0b92f966164d1fcd77b66405545ed60e534 Mon Sep 17 00:00:00 2001 From: Rithvik-padma Date: Sat, 23 Dec 2023 11:15:09 +0530 Subject: [PATCH 7/9] feat: make publish card screen-reader accessible --- src/app/components/PublisherCard/index.tsx | 1 + src/app/components/ScreenHeader/index.tsx | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/app/components/PublisherCard/index.tsx b/src/app/components/PublisherCard/index.tsx index f316829f50..df3baf9715 100644 --- a/src/app/components/PublisherCard/index.tsx +++ b/src/app/components/PublisherCard/index.tsx @@ -29,6 +29,7 @@ export default function PublisherCard({ } return (
+
{title}
); From 721daf3da523f00ba20c87efd307c17a30161042 Mon Sep 17 00:00:00 2001 From: Rithvik-padma Date: Sat, 23 Dec 2023 11:39:54 +0530 Subject: [PATCH 8/9] feat: add arrowkeys trverse message in account menu --- src/app/components/AccountMenu/index.tsx | 4 ++++ src/i18n/locales/en/translation.json | 1 + 2 files changed, 5 insertions(+) diff --git a/src/app/components/AccountMenu/index.tsx b/src/app/components/AccountMenu/index.tsx index 8b28b8ef8f..2502313f41 100644 --- a/src/app/components/AccountMenu/index.tsx +++ b/src/app/components/AccountMenu/index.tsx @@ -93,8 +93,12 @@ function AccountMenu({ showOptions = true }: Props) {
+ + {tCommon("arrowkeys")} +
Date: Sat, 23 Dec 2023 11:45:15 +0530 Subject: [PATCH 9/9] feat: add arrowkeys trverse message in user menu --- src/app/components/UserMenu/index.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/app/components/UserMenu/index.tsx b/src/app/components/UserMenu/index.tsx index b1f40c2ceb..54973b858d 100644 --- a/src/app/components/UserMenu/index.tsx +++ b/src/app/components/UserMenu/index.tsx @@ -46,6 +46,9 @@ export default function UserMenu() { + + {tCommon("arrowkeys")} +
{