Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add invoices list pagination #337

Open
lujakob opened this issue Mar 25, 2023 · 0 comments
Open

feat: add invoices list pagination #337

lujakob opened this issue Mar 25, 2023 · 0 comments

Comments

@lujakob
Copy link

lujakob commented Mar 25, 2023

In the context of discussing the feature of paginated transactions data (incoming/outgoing) for the lightning-browser-extension with @reneaaron recently, I was doing some research about the API capabilities of the different connectors we use. For a lot of connectors we don't even support displaying invoices yet. LND and CLN have limited support so far, but might have support soon. I also checked the lndhub.go codebase and found there is no support for paginated invoices yet. The response is limited to the latest 100 entries.

However as we have full control of the code, it is not difficult to implement and we might want to use paginated transactions at least for Alby accounts, I propose to implement it.

As I debugged the codebase recently and got curious I implemented a draft version. Please have a look. If you think it generally makes sense, I am happy to receive some feedback and move along implementing it.

Important to consider is, this would lead to breaking changes as it changes the API response object for the invoices endpoint.

lujakob#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant